From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 15 Mar 2013 17:13:54 -0400 Subject: [U-Boot] [PATCH 1/4] am33xx: add pll and clock support for TI814x CPSW In-Reply-To: <1363381100-6364-2-git-send-email-mporter@ti.com> References: <1363381100-6364-1-git-send-email-mporter@ti.com> <1363381100-6364-2-git-send-email-mporter@ti.com> Message-ID: <20130315211354.GC20201@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Mar 15, 2013 at 04:58:17PM -0400, Matt Porter wrote: [snip] > + /* Ethernet */ > + writel(PRCM_MOD_EN, &cmalwon->l3slowclkstctrl); > + while ((readl(&cmalwon->l3slowclkstctrl) & 0x2100) != 0x2100) > + ; > + writel(PRCM_MOD_EN, &cmalwon->ethclkstctrl); > + writel(PRCM_MOD_EN, &cmalwon->ethernet0clkctrl); > + while ((readl(&cmalwon->ethernet0clkctrl) & 0x30000) != 0) > + ; > + writel(PRCM_MOD_EN, &cmalwon->ethernet1clkctrl); > + while ((readl(&cmalwon->ethernet1clkctrl) & 0x30000) != 0) Please define away the magic numbers. [snip] > +void sata_pll_config(void) > +{ > + /* TRM 21.3.1 */ > + writel(0xc12c003c, &spll->pllcfg1); I'm OK with comments, but please make it a multi-line thing that explains what's going on so that it's clear that yes, really, we shouldn't have defined these. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: