From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix bootdelay timeout calculation when SYS_HZ!=1000
Date: Thu, 21 Mar 2013 07:55:53 +0100 [thread overview]
Message-ID: <20130321065553.BC624200547@gemini.denx.de> (raw)
In-Reply-To: <1363842874-8286-1-git-send-email-swarren@wwwdotorg.org>
Dear Stephen Warren,
In message <1363842874-8286-1-git-send-email-swarren@wwwdotorg.org> you wrote:
> Commit b2f3e0e "console: USB: KBD: Fix incorrect autoboot timeout"
> re-wrote the bootdelay timeout loop. However, it hard-coded the value
> that get_delay() was expected to increment in one second, rather than
> calculating it based on CONFIG_SYS_HZ. On systems where SYS_HZ != 1000,
> this caused bootdelay timeout to be incorrect. Fix this.
Are there any such systems left? I agree with your patch, but if you
know of systems that use incorrect values of CONFIG_SYS_HZ then please
point these out so they can be fixed!
A system with CONFIG_SYS_HZ != 1000 is _broken_.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is dangerous to be right on a subject on which the established
authorities are wrong. -- Voltaire
next prev parent reply other threads:[~2013-03-21 6:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 5:14 [U-Boot] [PATCH] Fix bootdelay timeout calculation when SYS_HZ!=1000 Stephen Warren
2013-03-21 6:55 ` Wolfgang Denk [this message]
2013-03-21 13:50 ` Tom Rini
2013-03-21 14:35 ` Wolfgang Denk
2013-03-21 14:41 ` Tom Rini
2013-03-21 15:25 ` Jon Hunter
2013-03-21 15:28 ` Tom Rini
2013-03-21 18:07 ` Jon Hunter
2013-03-21 18:26 ` Tom Rini
2013-03-21 16:04 ` Stephen Warren
2013-03-21 19:17 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130321065553.BC624200547@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox