From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 16/21] T4240/eth: fix SGMII card PHY address
Date: Fri, 22 Mar 2013 21:57:47 +0100 [thread overview]
Message-ID: <20130322205747.7A03F2014CE@gemini.denx.de> (raw)
In-Reply-To: <1363973052-25918-14-git-send-email-yorksun@freescale.com>
Dear York Sun,
In message <1363973052-25918-14-git-send-email-yorksun@freescale.com> you wrote:
> From: Shaohui Xie <Shaohui.Xie@freescale.com>
>
> QSGMII card assumed to be used by default, but if SGMII card is used,
> it will use different PHY address, but we don't know which card is used
> until we access PHY on the card. So we check the card type slot by slot,
> if we can read a PHY ID by reading a SGMII PHY address on a slot, then
> the slot must have a SGMII card pluged, we mark all ports on that slot,
> and fix dts to use the SGMII card PHY address when doing dts fixup
> for the marked ports.
>
> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> ---
> board/freescale/t4qds/eth.c | 137 +++++++++++++++++++++++++++++++++++++++++--
> 1 file changed, 133 insertions(+), 4 deletions(-)
CHECK: Alignment should match open parenthesis
#139: FILE: board/freescale/t4qds/eth.c:196:
+ fdt_set_phy_handle(blob, prop, pa,
+ "sgmii_phy21");
CHECK: Alignment should match open parenthesis
#144: FILE: board/freescale/t4qds/eth.c:201:
+ fdt_set_phy_handle(blob, prop, pa,
+ "sgmii_phy22");
CHECK: Alignment should match open parenthesis
#149: FILE: board/freescale/t4qds/eth.c:206:
+ fdt_set_phy_handle(blob, prop, pa,
+ "sgmii_phy23");
CHECK: Alignment should match open parenthesis
#154: FILE: board/freescale/t4qds/eth.c:211:
+ fdt_set_phy_handle(blob, prop, pa,
+ "sgmii_phy24");
CHECK: Alignment should match open parenthesis
#159: FILE: board/freescale/t4qds/eth.c:216:
+ fdt_set_phy_handle(blob, prop, pa,
+ "sgmii_phy12");
CHECK: Alignment should match open parenthesis
#165: FILE: board/freescale/t4qds/eth.c:221:
+ fdt_set_phy_handle(blob, prop, pa,
+ "sgmii_phy14");
CHECK: Alignment should match open parenthesis
#168: FILE: board/freescale/t4qds/eth.c:224:
+ fdt_set_phy_handle(blob, prop, pa,
+ "phy_sgmii4");
CHECK: Alignment should match open parenthesis
#174: FILE: board/freescale/t4qds/eth.c:229:
+ fdt_set_phy_handle(blob, prop, pa,
+ "sgmii_phy13");
CHECK: Alignment should match open parenthesis
#177: FILE: board/freescale/t4qds/eth.c:232:
+ fdt_set_phy_handle(blob, prop, pa,
+ "phy_sgmii3");
CHECK: Alignment should match open parenthesis
#182: FILE: board/freescale/t4qds/eth.c:237:
+ fdt_set_phy_handle(blob, prop, pa,
+ "sgmii_phy41");
CHECK: Alignment should match open parenthesis
#187: FILE: board/freescale/t4qds/eth.c:242:
+ fdt_set_phy_handle(blob, prop, pa,
+ "sgmii_phy42");
CHECK: Alignment should match open parenthesis
#192: FILE: board/freescale/t4qds/eth.c:247:
+ fdt_set_phy_handle(blob, prop, pa,
+ "sgmii_phy43");
CHECK: Alignment should match open parenthesis
#197: FILE: board/freescale/t4qds/eth.c:252:
+ fdt_set_phy_handle(blob, prop, pa,
+ "sgmii_phy44");
CHECK: Alignment should match open parenthesis
#202: FILE: board/freescale/t4qds/eth.c:257:
+ fdt_set_phy_handle(blob, prop, pa,
+ "sgmii_phy32");
CHECK: Alignment should match open parenthesis
#208: FILE: board/freescale/t4qds/eth.c:262:
+ fdt_set_phy_handle(blob, prop, pa,
+ "sgmii_phy34");
CHECK: Alignment should match open parenthesis
#211: FILE: board/freescale/t4qds/eth.c:265:
+ fdt_set_phy_handle(blob, prop, pa,
+ "phy_sgmii12");
CHECK: Alignment should match open parenthesis
#217: FILE: board/freescale/t4qds/eth.c:270:
+ fdt_set_phy_handle(blob, prop, pa,
+ "sgmii_phy33");
CHECK: Alignment should match open parenthesis
#220: FILE: board/freescale/t4qds/eth.c:273:
+ fdt_set_phy_handle(blob, prop, pa,
+ "phy_sgmii11");
CHECK: Alignment should match open parenthesis
#241: FILE: board/freescale/t4qds/eth.c:350:
+ if (miiphy_read(mdio_names[i],
+ SGMII_CARD_PORT1_PHY_ADDR, MII_PHYSID2, ®) != 0) {
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A witty saying proves nothing, but saying something pointless gets
people's attention.
next prev parent reply other threads:[~2013-03-22 20:57 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 17:23 [U-Boot] [PATCH 03/21] fsl_ifc: add support for different IFC bank count York Sun
2013-03-22 17:23 ` [U-Boot] [PATCH 04/21] powerpc/mpc85xx b8460 PCIe registers are not at QORIQ_CHASSIS2 location York Sun
2013-03-22 17:23 ` [U-Boot] [PATCH 05/21] powerpc/mpc85xx: Add setting of clock-frequency for T4/B4 clockgen node York Sun
2013-03-22 20:54 ` Wolfgang Denk
2013-03-22 17:23 ` [U-Boot] [PATCH 06/21] t4240qds/eth: fixup ethernet for t4240qds York Sun
2013-03-22 17:23 ` [U-Boot] [PATCH 07/21] net/fm: fixup ethernet for mEMAC York Sun
2013-03-22 20:55 ` Wolfgang Denk
2013-03-22 17:23 ` [U-Boot] [PATCH 08/21] powerpc/85xx: fix build error introduced by serdes_get_prtcl York Sun
2013-03-22 17:24 ` [U-Boot] [PATCH 09/21] net/phy: add VSC8574 support York Sun
2013-03-22 20:55 ` Wolfgang Denk
2013-03-22 17:24 ` [U-Boot] [PATCH 10/21] T4240/net: use QSGMII card PHY address by default York Sun
2013-03-22 17:24 ` [U-Boot] [PATCH 11/21] T4/usb: move usb 2.0 utmi dual phy init code to cpu_init.c York Sun
2013-03-22 17:24 ` [U-Boot] [PATCH 12/21] powerpc/mpc85xx: Update workaround for DDR erratum A-004934 York Sun
2013-03-22 17:24 ` [U-Boot] [PATCH 13/21] powerpc/mpc8xxx: Allow board file to override DDR address assignment York Sun
2013-03-22 17:24 ` [U-Boot] [PATCH 14/21] powerpc/b4860qds: Assign DDR address in board file York Sun
2013-03-22 20:57 ` Wolfgang Denk
2013-03-22 17:24 ` [U-Boot] [PATCH 15/21] powerpc/t4qds: Fix disabling remote I2C connection York Sun
2013-03-22 17:24 ` [U-Boot] [PATCH 16/21] T4240/eth: fix SGMII card PHY address York Sun
2013-03-22 20:57 ` Wolfgang Denk [this message]
2013-03-22 17:24 ` [U-Boot] [PATCH 17/21] powerpc/srio: Remove duplicate macro definitions York Sun
2013-03-22 17:24 ` [U-Boot] [PATCH 18/21] powerpc/boot: Change the macro of Boot from SRIO and PCIE master module York Sun
2013-03-22 17:24 ` [U-Boot] [PATCH 19/21] powerpc/b4860qds: Add the tlb entries for SRIO interfaces York Sun
2013-03-22 20:58 ` Wolfgang Denk
2013-03-22 17:24 ` [U-Boot] [PATCH 20/21] powerpc/b4860qds: Master module for boot from SRIO and PCIE York Sun
2013-03-22 17:24 ` [U-Boot] [PATCH 21/21] powerpc/b4860qds: Slave " York Sun
2013-03-22 20:58 ` Wolfgang Denk
2013-05-10 21:49 ` [U-Boot] [PATCH 03/21] fsl_ifc: add support for different IFC bank count Andy Fleming
2013-05-14 8:59 ` Hu Mingkai-B21284
2013-05-14 14:43 ` Fleming Andy-AFLEMING
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130322205747.7A03F2014CE@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox