From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 8/8] Add TI816X evm board support
Date: Thu, 28 Mar 2013 17:49:59 -0400 [thread overview]
Message-ID: <20130328214959.GK5711@bill-the-cat> (raw)
In-Reply-To: <3465D313FDFB824F9A9C8CD24FA4F6BC0112A9F3@frontmail.adetel.com>
On Thu, Mar 28, 2013 at 06:14:41PM +0100, TENART Antoine wrote:
> ---
> MAINTAINERS | 4 +
> arch/arm/include/asm/arch-am33xx/spl.h | 9 +
> board/ti/ti816x/Makefile | 48 ++
> board/ti/ti816x/evm.c | 753 ++++++++++++++++++++++++++++++++
This file has a large number of style problems, both things I know
checkpatch will catch as well as inconsistent spacing throughout and
/*
* All multiline comments must look
* like this.
*/
[snip]
> +#define CONFIG_SYS_BAUDRATE_TABLE { 110, 300, 600, 1200, 2400, \
> +4800, 9600, 14400, 19200, 28800, 38400, 56000, 57600, 115200 }
Please use the fallback table instead of this. And I snipped it before
I recalled, but you also should have enough memory to keep longhelp :)
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130328/03a074ac/attachment.pgp>
prev parent reply other threads:[~2013-03-28 21:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1364490881-25921-1-git-send-email-atenart@adeneo-embedded.com>
2013-03-28 17:14 ` [U-Boot] [PATCH 1/8] Prepare for TI816X : reuse existing code from TI814X TENART Antoine
2013-03-28 21:02 ` Peter Korsgaard
2013-03-28 21:50 ` Tom Rini
2013-03-28 22:05 ` Peter Korsgaard
2013-03-29 9:09 ` TENART Antoine
2013-03-29 12:30 ` Tom Rini
2013-03-28 17:14 ` [U-Boot] [PATCH 2/8] Add TI816X mux definitions TENART Antoine
2013-03-28 21:04 ` Peter Korsgaard
2013-03-28 21:52 ` Tom Rini
2013-03-29 9:11 ` TENART Antoine
2013-03-28 17:14 ` [U-Boot] [PATCH 3/8] Add TI816X clocks definitions TENART Antoine
2013-03-28 21:52 ` Tom Rini
2013-03-28 17:14 ` [U-Boot] [PATCH 4/8] Add TI816X ddr definitions TENART Antoine
2013-03-28 21:52 ` Tom Rini
2013-03-28 17:14 ` [U-Boot] [PATCH 5/8] Add TI816X cpu definitions TENART Antoine
2013-03-28 21:24 ` Peter Korsgaard
2013-03-29 10:17 ` TENART Antoine
2013-03-28 17:14 ` [U-Boot] [PATCH 6/8] Add TI816X specific register definitions TENART Antoine
2013-03-28 21:37 ` Peter Korsgaard
2013-03-28 21:52 ` Tom Rini
2013-03-28 17:14 ` [U-Boot] [PATCH 7/8] Add TI816X mmc clock reference TENART Antoine
2013-03-28 21:14 ` Peter Korsgaard
2013-03-28 17:14 ` [U-Boot] [PATCH 8/8] Add TI816X evm board support TENART Antoine
2013-03-28 21:49 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130328214959.GK5711@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox