From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/8] Add TI816X specific register definitions
Date: Thu, 28 Mar 2013 17:52:47 -0400 [thread overview]
Message-ID: <20130328215247.GG30253@bill-the-cat> (raw)
In-Reply-To: <874nfv2okn.fsf@dell.be.48ers.dk>
On Thu, Mar 28, 2013 at 10:37:28PM +0100, Peter Korsgaard wrote:
> >>>>> "TENART" == TENART Antoine <atenart@adeneo-embedded.com> writes:
>
> TENART> Also move some non common defintions from hardware.h
> TENART> ---
> TENART> arch/arm/include/asm/arch-am33xx/hardware.h | 7 +--
> TENART> arch/arm/include/asm/arch-am33xx/hardware_am33xx.h | 5 ++
> TENART> arch/arm/include/asm/arch-am33xx/hardware_ti814x.h | 5 ++
> TENART> arch/arm/include/asm/arch-am33xx/hardware_ti816x.h | 58 ++++++++++++++++++++
> TENART> 4 files changed, 70 insertions(+), 5 deletions(-)
> TENART> create mode 100644 arch/arm/include/asm/arch-am33xx/hardware_ti816x.h
>
> ..
>
> TENART> +#define DDRPHY_0_CONFIG_BASE 0x48198000
> TENART> +#define DDRPHY_1_CONFIG_BASE 0x4819a000
> TENART> +#define DDRPHY_CONFIG_BASE ((emif == 0) ? DDRPHY_0_CONFIG_BASE:DDRPHY_1_CONFIG_BASE)
> TENART> +
> TENART> +/* CPSW Config space */
> TENART> +#define CPSW_MDIO_BASE 0x4A100800
>
> ti816x doesn't have CPSW, so the name is a bit odd (the base address
> matches the emac mdio module). The emac driver expects an
> asm/arch/emac_defs.h header with a EMAC_MDIO_BASE_ADDR define (among
> others).
>
> Perhaps just drop it from here as you're not adding emac support in this
> series anyway.
Agreed, and please check the whole series over for other unused defines.
We shouldn't import things we aren't using.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130328/c045bc39/attachment.pgp>
next prev parent reply other threads:[~2013-03-28 21:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1364490881-25921-1-git-send-email-atenart@adeneo-embedded.com>
2013-03-28 17:14 ` [U-Boot] [PATCH 1/8] Prepare for TI816X : reuse existing code from TI814X TENART Antoine
2013-03-28 21:02 ` Peter Korsgaard
2013-03-28 21:50 ` Tom Rini
2013-03-28 22:05 ` Peter Korsgaard
2013-03-29 9:09 ` TENART Antoine
2013-03-29 12:30 ` Tom Rini
2013-03-28 17:14 ` [U-Boot] [PATCH 2/8] Add TI816X mux definitions TENART Antoine
2013-03-28 21:04 ` Peter Korsgaard
2013-03-28 21:52 ` Tom Rini
2013-03-29 9:11 ` TENART Antoine
2013-03-28 17:14 ` [U-Boot] [PATCH 3/8] Add TI816X clocks definitions TENART Antoine
2013-03-28 21:52 ` Tom Rini
2013-03-28 17:14 ` [U-Boot] [PATCH 4/8] Add TI816X ddr definitions TENART Antoine
2013-03-28 21:52 ` Tom Rini
2013-03-28 17:14 ` [U-Boot] [PATCH 5/8] Add TI816X cpu definitions TENART Antoine
2013-03-28 21:24 ` Peter Korsgaard
2013-03-29 10:17 ` TENART Antoine
2013-03-28 17:14 ` [U-Boot] [PATCH 6/8] Add TI816X specific register definitions TENART Antoine
2013-03-28 21:37 ` Peter Korsgaard
2013-03-28 21:52 ` Tom Rini [this message]
2013-03-28 17:14 ` [U-Boot] [PATCH 7/8] Add TI816X mmc clock reference TENART Antoine
2013-03-28 21:14 ` Peter Korsgaard
2013-03-28 17:14 ` [U-Boot] [PATCH 8/8] Add TI816X evm board support TENART Antoine
2013-03-28 21:49 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130328215247.GG30253@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox