From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Fri, 29 Mar 2013 11:56:45 +0100 Subject: [U-Boot] [PATCH] common/lcd.c: cleanup use of global variables In-Reply-To: <1357415148-9243-1-git-send-email-wd@denx.de> References: <50E86DFC.20304@myspectrum.nl> <1357415148-9243-1-git-send-email-wd@denx.de> Message-ID: <20130329115645.3a9d4245@crub> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Wolfgang, On Sat, 5 Jan 2013 20:45:48 +0100 Wolfgang Denk wrote: > lcd_color_fg and lcd_color_bg had to be declared in board specific > code, but were not actually used there; in addition, we have getter / > setter functions for these, which were not used either. > > Get rid of the global variables, and use the getter function where > needed (so far no setter calls are needed). > > Signed-off-by: Wolfgang Denk > Cc: Alessandro Rubini > Cc: Anatolij Gustschin > Cc: Bo Shen > Cc: Haavard Skinnemoen > Cc: Kyungmin Park > Cc: Marek Vasut > Cc: Minkyu Kang > Cc: Nikita Kiryanov > Cc: Simon Glass > Cc: Stelian Pop > Cc: Tom Warren > --- > arch/arm/cpu/pxa/pxafb.c | 2 -- > arch/powerpc/cpu/mpc8xx/lcd.c | 3 --- > board/mcc200/lcd.c | 3 --- > common/lcd.c | 7 ++++--- > drivers/video/amba.c | 2 -- > drivers/video/atmel_hlcdfb.c | 2 -- > drivers/video/atmel_lcdfb.c | 2 -- > drivers/video/exynos_fb.c | 2 -- > drivers/video/tegra.c | 4 +--- > include/lcd.h | 6 +++--- > 10 files changed, 8 insertions(+), 25 deletions(-) Patch rebased and merged, thanks! Anatolij