public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 00/10] common.lcd: remove globals and cleanup
Date: Fri, 29 Mar 2013 12:03:13 +0100	[thread overview]
Message-ID: <20130329120313.21ca8dc5@crub> (raw)
In-Reply-To: <1358887454-9541-1-git-send-email-jeroen@myspectrum.nl>

Hi,

On Tue, 22 Jan 2013 21:44:06 +0100
Jeroen Hofstee <jeroen@myspectrum.nl> wrote:

> As mentioned in http://lists.denx.de/pipermail/u-boot/2013-January/143459.html
> there does not seem to be a good reason why the frame buffer driver
> provide the variables for the lcd internal logic. So lets just remove it.
> If there is any good reason for a framebuffer driver to "call up" it should
> do so by a function call and not change the lcd its internal state (and
> there is actually none doing so at the moment).
> 
> This patchset first removes unused drivers and places drivers useing
> common/lcd.c in drivers/video. Then removes the unneeded globals and
> thereafter finishes with some cleanups.
> 
> This patch goes after http://patchwork.ozlabs.org/patch/209692/
> "common/lcd.c: cleanup use of global variables"
> 
> Version 2:
>  Marek Vasut <marex@denx.de>: use format-patch -M to detect moves
>  Adjust the commit message not to exceed the max line length
>  Fix malformed email address.
>  check-patch clean (adjusted a space in patch 6)
>  remove bouncing email addresses and add acks
>  patch 7 and 10 are unchanged and not reposted
> 
> Jeroen Hofstee (10):
>   lcd, amba: remove this driver since it is not used
>   lcd, tegra: remove unused cursor functions
>   lcd, mpc8xx: move the mpc8xx driver to drivers/video
>   lcd, pxafb: move the pxafb to drivers/video
>   common/lcd.c: cleanup use of global variables
>   common/lcd.c: remove global lcd_base
>   common/lcd: cosmetic: clean up a bit
>   lcd, fb: remove duplicated prototypes and unused code
>   api/api_display: use the getters for console size info
>   common/lcd.c: move the macro's to the c file
> 
>  api/api_display.c                                  |    4 +-
>  arch/arm/cpu/pxa/Makefile                          |    1 -
>  arch/powerpc/cpu/mpc8xx/Makefile                   |    1 -
>  board/mcc200/lcd.c                                 |   21 +---
>  common/lcd.c                                       |  117 +++++++++++---------
>  drivers/video/Makefile                             |    3 +-
>  drivers/video/amba.c                               |   77 -------------
>  drivers/video/atmel_hlcdfb.c                       |    8 --
>  drivers/video/atmel_lcdfb.c                        |    8 --
>  drivers/video/exynos_fb.c                          |   14 +--
>  .../cpu/mpc8xx/lcd.c => drivers/video/mpc8xx_lcd.c |   58 +---------
>  .../arm/cpu/pxa/pxafb.c => drivers/video/pxa_lcd.c |   41 -------
>  drivers/video/tegra.c                              |   64 +----------
>  include/configs/R360MPI.h                          |    1 +
>  include/configs/RBC823.h                           |    1 +
>  include/configs/RPXlite_DW.h                       |    1 +
>  include/configs/RRvision.h                         |    4 +-
>  include/configs/TQM823L.h                          |    1 +
>  include/configs/TQM823M.h                          |    1 +
>  include/configs/lubbock.h                          |    1 +
>  include/configs/lwmon.h                            |    1 +
>  include/configs/palmld.h                           |    1 +
>  include/configs/palmtc.h                           |    1 +
>  include/configs/pxa255_idp.h                       |    1 +
>  include/configs/svm_sc8xx.h                        |    1 +
>  include/configs/v37.h                              |    1 +
>  include/configs/zipitz2.h                          |    1 +
>  include/lcd.h                                      |   71 +++---------
>  28 files changed, 109 insertions(+), 396 deletions(-)
>  delete mode 100644 drivers/video/amba.c
>  rename arch/powerpc/cpu/mpc8xx/lcd.c => drivers/video/mpc8xx_lcd.c (92%)
>  rename arch/arm/cpu/pxa/pxafb.c => drivers/video/pxa_lcd.c (93%)

Merged this series after rebasing, also merged patches
7 and 10 from previous series. Thanks!

Anatolij

      parent reply	other threads:[~2013-03-29 11:03 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-12 22:07 [U-Boot] [PATCH 00/10] common.lcd: remove globals and cleanup Jeroen Hofstee
2013-01-12 22:07 ` [U-Boot] [PATCH 01/10] lcd, amba: remove this frame buffer driver since it is not used Jeroen Hofstee
2013-01-13 16:15   ` Alessandro Rubini
2013-01-12 22:07 ` [U-Boot] [PATCH 02/10] lcd, tegra: remove unused cursor functions Jeroen Hofstee
2013-01-12 22:17   ` Jeroen Hofstee
2013-01-25 20:38   ` Simon Glass
2013-01-25 21:18     ` Tom Warren
2013-01-26 16:20       ` Jeroen Hofstee
2013-01-28 16:19         ` Tom Warren
2013-01-12 22:07 ` [U-Boot] [PATCH 03/10] lcd, mpc8xx: move the mpc8xx frame buffer driver to drivers/video Jeroen Hofstee
2013-01-12 22:07 ` [U-Boot] [PATCH 04/10] lcd, pxafb: move the pxafb " Jeroen Hofstee
2013-01-13  0:37   ` Marek Vasut
2013-01-12 22:07 ` [U-Boot] [PATCH 05/10] common/lcd.c: cleanup use of global variables Jeroen Hofstee
2013-01-16  1:23   ` Bo Shen
2013-01-12 22:07 ` [U-Boot] [PATCH 06/10] common/lcd.c: remove global lcd_base Jeroen Hofstee
2013-01-16  1:24   ` Bo Shen
2013-01-12 22:07 ` [U-Boot] [PATCH 07/10] common/lcd: cosmetic: clean up a bit Jeroen Hofstee
2013-03-29 11:04   ` Anatolij Gustschin
2013-01-12 22:07 ` [U-Boot] [PATCH 08/10] lcd, fb: cleanup, remove prototypes already in lcd.h and unused code Jeroen Hofstee
2013-01-12 22:07 ` [U-Boot] [PATCH 09/10] api/api_display: use the getters for console size info Jeroen Hofstee
2013-01-15 18:14   ` Che-liang Chiou
2013-01-12 22:07 ` [U-Boot] [PATCH 10/10] common/lcd.c: move the macro's to the c file Jeroen Hofstee
2013-03-29 11:05   ` Anatolij Gustschin
2013-01-22 20:44 ` [U-Boot] [PATCH v2 00/10] common.lcd: remove globals and cleanup Jeroen Hofstee
2013-01-22 20:44   ` [U-Boot] [PATCH v2 01/10] lcd, amba: remove this driver since it is not used Jeroen Hofstee
2013-01-22 20:44   ` [U-Boot] [PATCH v2 02/10] lcd, tegra: remove unused cursor functions Jeroen Hofstee
2013-01-22 20:44   ` [U-Boot] [PATCH v2 03/10] lcd, mpc8xx: move the mpc8xx driver to drivers/video Jeroen Hofstee
2013-01-22 20:44   ` [U-Boot] [PATCH v2 04/10] lcd, pxafb: move the pxafb " Jeroen Hofstee
2013-01-22 20:44   ` [U-Boot] [PATCH v2 05/10] common/lcd.c: cleanup use of global variables Jeroen Hofstee
2013-01-22 20:44   ` [U-Boot] [PATCH v2 06/10] common/lcd.c: remove global lcd_base Jeroen Hofstee
2013-01-22 20:44   ` [U-Boot] [PATCH v2 08/10] lcd, fb: remove duplicated prototypes and unused code Jeroen Hofstee
2013-01-22 20:44   ` [U-Boot] [PATCH v2 09/10] api/api_display: use the getters for console size info Jeroen Hofstee
2013-03-29 11:03   ` Anatolij Gustschin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130329120313.21ca8dc5@crub \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox