From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/7] usb: hub: Fix enumration timeout
Date: Tue, 2 Apr 2013 07:12:07 +0200 [thread overview]
Message-ID: <201304020712.07684.marex@denx.de> (raw)
In-Reply-To: <CAFp+6iGSrrbOrVTQk_TVW8rP9ttA0_xi3ojKpGAeM7w6Hi6ARg@mail.gmail.com>
Dear Vivek Gautam,
> Hi,
>
> On Tue, Apr 2, 2013 at 1:43 AM, Tom Rini <trini@ti.com> wrote:
> > On Wed, Mar 27, 2013 at 02:59:00PM +0530, Vivek Gautam wrote:
> >> Patch b6d7852c increases timeout for enumeration, taking
> >> worst case to be 10 sec.
> >> get_timer() api returns timestamp in micro-seconds, which is
> >> what we are checking in the do-while() loop in usb_hub_configure()
> >> (get_timer(start) < CONFIG_SYS_HZ * 10).
> >> This should give us a required check for 10 seconds, and thereby
> >> we don't need to add additional mdelay of 100 microseconds in
> >> each cycle.
> >
> > The wording here is not correct. get_timer operates in milliseconds not
> > microseconds.
>
> Oops!! Yes of course, my mistake. Thanks
I have the patches queued in usb/next, you can send me a fix and I'll squash it
with what's already in there.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-04-02 5:12 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 9:28 [U-Boot] [PATCH 0/7] usb: ss: Some fixes and cleanup for USB super-speed support Vivek Gautam
2013-03-27 9:28 ` [U-Boot] [PATCH 1/7] USB: Some cleanup prior to USB 3.0 interface addition Vivek Gautam
2013-03-28 14:26 ` Marek Vasut
2013-04-02 5:54 ` Vivek Gautam
2013-04-02 5:56 ` Vivek Gautam
2013-04-02 6:26 ` Marek Vasut
2013-04-02 6:37 ` Vivek Gautam
2013-04-02 6:46 ` Marek Vasut
2013-04-02 6:58 ` Vivek Gautam
2013-03-27 9:28 ` [U-Boot] [PATCH 2/7] usb: hub: Conditionally power on usb's root-hub ports Vivek Gautam
2013-03-28 14:28 ` Marek Vasut
2013-04-02 9:36 ` Vivek Gautam
2013-04-02 10:09 ` Marek Vasut
2013-04-02 10:29 ` Vivek Gautam
2013-04-02 10:33 ` Marek Vasut
2013-03-27 9:28 ` [U-Boot] [PATCH 3/7] usb: Update device class in usb device's descriptor Vivek Gautam
2013-03-28 14:28 ` Marek Vasut
2013-04-02 9:32 ` Vivek Gautam
2013-04-02 10:09 ` Marek Vasut
2013-04-02 10:30 ` Vivek Gautam
2013-03-27 9:29 ` [U-Boot] [PATCH 4/7] usb: hub: Fix enumration timeout Vivek Gautam
2013-03-28 3:33 ` Vipin Kumar
2013-04-01 20:13 ` Tom Rini
2013-04-02 4:55 ` Vivek Gautam
2013-04-02 5:12 ` Marek Vasut [this message]
2013-04-02 5:34 ` Vivek Gautam
2013-04-02 5:36 ` Vivek Gautam
2013-04-02 6:43 ` Marek Vasut
2013-03-27 9:29 ` [U-Boot] [PATCH 5/7] usb: hub: Increase device enumeration timeout for broken drives Vivek Gautam
2013-03-28 14:32 ` Marek Vasut
2013-04-02 9:33 ` Vivek Gautam
2013-04-02 13:53 ` Vivek Gautam
2013-04-04 3:58 ` Marek Vasut
2013-04-04 10:57 ` Vivek Gautam
2013-04-14 17:17 ` Marek Vasut
2013-03-27 9:29 ` [U-Boot] [PATCH 6/7] USB: SS: Add support for Super Speed USB interface Vivek Gautam
2013-03-28 14:35 ` Marek Vasut
2013-04-02 9:52 ` Vivek Gautam
2013-03-27 9:29 ` [U-Boot] [PATCH 7/7] usb: eth: Fix for updated usb interface descriptor structure Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304020712.07684.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox