From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 2 Apr 2013 07:12:07 +0200 Subject: [U-Boot] [PATCH 4/7] usb: hub: Fix enumration timeout In-Reply-To: References: <1364376543-7526-1-git-send-email-gautam.vivek@samsung.com> <20130401201303.GA15196@bill-the-cat> Message-ID: <201304020712.07684.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Vivek Gautam, > Hi, > > On Tue, Apr 2, 2013 at 1:43 AM, Tom Rini wrote: > > On Wed, Mar 27, 2013 at 02:59:00PM +0530, Vivek Gautam wrote: > >> Patch b6d7852c increases timeout for enumeration, taking > >> worst case to be 10 sec. > >> get_timer() api returns timestamp in micro-seconds, which is > >> what we are checking in the do-while() loop in usb_hub_configure() > >> (get_timer(start) < CONFIG_SYS_HZ * 10). > >> This should give us a required check for 10 seconds, and thereby > >> we don't need to add additional mdelay of 100 microseconds in > >> each cycle. > > > > The wording here is not correct. get_timer operates in milliseconds not > > microseconds. > > Oops!! Yes of course, my mistake. Thanks I have the patches queued in usb/next, you can send me a fix and I'll squash it with what's already in there. Best regards, Marek Vasut