From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Tue, 2 Apr 2013 12:32:40 +0200 Subject: [U-Boot] [PATCH] biosemu: include header In-Reply-To: References: <1364890454-5659-1-git-send-email-linus.walleij@linaro.org> <20130402105658.6304114c@lilith> Message-ID: <20130402123240.7ba96cd9@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Linus, On Tue, 2 Apr 2013 12:09:21 +0200, Linus Walleij wrote: > On Tue, Apr 2, 2013 at 10:56 AM, Albert ARIBAUD > wrote: > > > NAK -- no ARM target needs bios emulation, so basing the #define on ARM > > requirements is incorrect. > > > > Actually, ARM targets build drivers/bios_emulator/libatibiosemu.o as > > the result of an overlook in ./Makefile where this object is compiled > > unconditionally. > > > > A git grep CONFIG_BIOSEMU seems to indicate only a handful of PowerPC > > targets need bios emulation; I suggest doing a V2 of this patch > > where the object is built only for PowerPC, and the #define is removed. > > So the patch was initiated by the discussion here: > http://marc.info/?l=linux-arm-kernel&m=136399798826572&w=2 > > I am looking into getting biosemu up on ARM for the PCI-equipped > ARM boards, but admittedly I have no idea where it'll go. > > But this can surely wait until I have a series that can be run as well. Indeed: when some real ARM target needs biosemu, then yes, this patch will make sense as part of the series that introduces this target. > Yours, > Linus Walleij Amicalement, -- Albert.