public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/7] usb: hub: Increase device enumeration timeout for broken drives
Date: Thu, 4 Apr 2013 05:58:10 +0200	[thread overview]
Message-ID: <201304040558.10304.marex@denx.de> (raw)
In-Reply-To: <CAFp+6iFLTUjwDs=2TaHmey=qgiAM7SZu1JZApK5bsBZ3wR3qVA@mail.gmail.com>

Dear Vivek Gautam,

> Hi Marek,
> 
> On Thu, Mar 28, 2013 at 8:02 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Vivek Gautam,
> > 
> >> Few broken usb mass storage devices can take some time to set
> >> Current Connect Status (CCS) and Connect Status Change (CSC) in
> >> Port status register after an attach.
> >> So increasing some timeout when both CCS and CSC bits are not set.
> >> 
> >> Signed-off-by: Amar <amarendra.xt@samsung.com>
> >> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> > 
> > Can we not postpone checking of these CCS and CSC bits for such broken
> > devices? This'd at least allow the "good" devices to be detected quickly
> > and while these are handled, this would give some time for the "bad"
> > ones to do their job too.
> 
> We are thinking of one approach here.
> Iterating over all the ports once, so that we find 'good' ports and 'bad'
> ports By 'bad' port we mean that either the device connected to it is bad
> or nothing is connected
> to this port.
> Once we are done with "usb_hub_port_connect_change()" and other jobs
> for 'good' ports,
> we iterate once again on bad ports.
> Not sure how good this approach :-(.  Any suggestions ?

That might just work, but I wonder if it's worth it. It's a pity we can't make a 
list of those as they're not even probed yet :(

Best regards,
Marek Vasut

  reply	other threads:[~2013-04-04  3:58 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27  9:28 [U-Boot] [PATCH 0/7] usb: ss: Some fixes and cleanup for USB super-speed support Vivek Gautam
2013-03-27  9:28 ` [U-Boot] [PATCH 1/7] USB: Some cleanup prior to USB 3.0 interface addition Vivek Gautam
2013-03-28 14:26   ` Marek Vasut
2013-04-02  5:54     ` Vivek Gautam
2013-04-02  5:56       ` Vivek Gautam
2013-04-02  6:26       ` Marek Vasut
2013-04-02  6:37         ` Vivek Gautam
2013-04-02  6:46           ` Marek Vasut
2013-04-02  6:58             ` Vivek Gautam
2013-03-27  9:28 ` [U-Boot] [PATCH 2/7] usb: hub: Conditionally power on usb's root-hub ports Vivek Gautam
2013-03-28 14:28   ` Marek Vasut
2013-04-02  9:36     ` Vivek Gautam
2013-04-02 10:09       ` Marek Vasut
2013-04-02 10:29         ` Vivek Gautam
2013-04-02 10:33           ` Marek Vasut
2013-03-27  9:28 ` [U-Boot] [PATCH 3/7] usb: Update device class in usb device's descriptor Vivek Gautam
2013-03-28 14:28   ` Marek Vasut
2013-04-02  9:32     ` Vivek Gautam
2013-04-02 10:09       ` Marek Vasut
2013-04-02 10:30         ` Vivek Gautam
2013-03-27  9:29 ` [U-Boot] [PATCH 4/7] usb: hub: Fix enumration timeout Vivek Gautam
2013-03-28  3:33   ` Vipin Kumar
2013-04-01 20:13   ` Tom Rini
2013-04-02  4:55     ` Vivek Gautam
2013-04-02  5:12       ` Marek Vasut
2013-04-02  5:34         ` Vivek Gautam
2013-04-02  5:36           ` Vivek Gautam
2013-04-02  6:43             ` Marek Vasut
2013-03-27  9:29 ` [U-Boot] [PATCH 5/7] usb: hub: Increase device enumeration timeout for broken drives Vivek Gautam
2013-03-28 14:32   ` Marek Vasut
2013-04-02  9:33     ` Vivek Gautam
2013-04-02 13:53     ` Vivek Gautam
2013-04-04  3:58       ` Marek Vasut [this message]
2013-04-04 10:57         ` Vivek Gautam
2013-04-14 17:17           ` Marek Vasut
2013-03-27  9:29 ` [U-Boot] [PATCH 6/7] USB: SS: Add support for Super Speed USB interface Vivek Gautam
2013-03-28 14:35   ` Marek Vasut
2013-04-02  9:52     ` Vivek Gautam
2013-03-27  9:29 ` [U-Boot] [PATCH 7/7] usb: eth: Fix for updated usb interface descriptor structure Vivek Gautam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201304040558.10304.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox