From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 4 Apr 2013 05:58:10 +0200 Subject: [U-Boot] [PATCH 5/7] usb: hub: Increase device enumeration timeout for broken drives In-Reply-To: References: <1364376543-7526-1-git-send-email-gautam.vivek@samsung.com> <201303281532.12603.marex@denx.de> Message-ID: <201304040558.10304.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Vivek Gautam, > Hi Marek, > > On Thu, Mar 28, 2013 at 8:02 PM, Marek Vasut wrote: > > Dear Vivek Gautam, > > > >> Few broken usb mass storage devices can take some time to set > >> Current Connect Status (CCS) and Connect Status Change (CSC) in > >> Port status register after an attach. > >> So increasing some timeout when both CCS and CSC bits are not set. > >> > >> Signed-off-by: Amar > >> Signed-off-by: Vivek Gautam > > > > Can we not postpone checking of these CCS and CSC bits for such broken > > devices? This'd at least allow the "good" devices to be detected quickly > > and while these are handled, this would give some time for the "bad" > > ones to do their job too. > > We are thinking of one approach here. > Iterating over all the ports once, so that we find 'good' ports and 'bad' > ports By 'bad' port we mean that either the device connected to it is bad > or nothing is connected > to this port. > Once we are done with "usb_hub_port_connect_change()" and other jobs > for 'good' ports, > we iterate once again on bad ports. > Not sure how good this approach :-(. Any suggestions ? That might just work, but I wonder if it's worth it. It's a pity we can't make a list of those as they're not even probed yet :( Best regards, Marek Vasut