From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] ARM: Add support for IGEP COM AQUILA/CYGNUS
Date: Thu, 4 Apr 2013 16:15:43 -0400 [thread overview]
Message-ID: <20130404201543.GC32357@bill-the-cat> (raw)
In-Reply-To: <CAFqH_51EBPg8o+GC7Fk7Kwdeet55YK_pyN2y0=nOvYJk2KDKbA@mail.gmail.com>
On Thu, Apr 04, 2013 at 09:51:05AM +0200, Enric Balletbo Serra wrote:
[snip]
> >> > +/*
> >> > + * memtest works on 8 MB in DRAM after skipping 32MB from
> >> > + * start addr of ram disk
> >> > + */
> >> > +#define CONFIG_SYS_MEMTEST_START (PHYS_DRAM_1 + (64 * 1024 * 1024))
> >> > +#define CONFIG_SYS_MEMTEST_END (CONFIG_SYS_MEMTEST_START
> >> \
> >> > + + (8 * 1024 * 1024))
> >>
> >> The comment is wrong, and you can do any of:
> >> - Opt-out of mtest (and see Wolfgang's readme on why that's probably a
> >> good idea)
> >>
> >
> > Readed and convinced. Thanks for this point.
> >
>
> As explained in Wolfgang's readme shouldn't remove CONFIG_CMD_MEMTEST from
> config_cmd_default.h ?
When the time comes, as stated in doc/feature-removal-schedule.txt :)
For now, #undef it.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130404/810dd067/attachment.pgp>
next prev parent reply other threads:[~2013-04-04 20:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 13:12 [U-Boot] [PATCH 0/2] Add initial support for AQUILA-CYGNUS Enric Balletbo i Serra
2013-04-03 13:12 ` [U-Boot] [PATCH 1/2] Add DDR3 support for IGEP COM AQUILA/CYGNUS Enric Balletbo i Serra
2013-04-03 13:12 ` [U-Boot] [PATCH 2/2] ARM: Add " Enric Balletbo i Serra
2013-04-03 22:38 ` Tom Rini
2013-04-04 7:36 ` Enric Balletbo Serra
2013-04-04 7:51 ` Enric Balletbo Serra
2013-04-04 20:15 ` Tom Rini [this message]
2013-04-04 20:17 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130404201543.GC32357@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox