From: "Pali Rohár" <pali.rohar@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] CRITICAL error in v2013.04-rc2 (true and false not working)
Date: Thu, 4 Apr 2013 23:19:38 +0200 [thread overview]
Message-ID: <201304042319.39473@pali> (raw)
In-Reply-To: <515DEB0E.7040709@freescale.com>
On Thursday 04 April 2013 23:05:18 York Sun wrote:
> On 04/04/2013 01:33 PM, Wolfgang Denk wrote:
> > Dear Pali Roh?r,
> >
> > In message <201304041946.55455@pali> you wrote:
> >> u-boot "true" and "false" hush commands are copiled
> >> incorrectly in uboot v2013.04-rc2
> >> (c8142633e169665b246352918df5b76fd243bb71)
> >>
> >> when I run help in u-boot it show:
> >>
> >> # help
> >> 0 - do nothing, unsuccessfully
> >> 1 - do nothing, successfully
> >> ? - alias for 'help'
> >> base - print or set address offset
> >> ...
> >>
> >> Instead "0" and "1" there should be "false" and "true"
> >> command.
> >
> > I confirm the problem.
> >
> > York, your commit 472d546 "Consolidate bool type" is causing
> > this issue, so I suggest you send a fix, please.
> >
> > Please check for other, similar use cases.
>
> I found the cause but I don't know the best fix. Please help.
>
> This is cause by common/cmd_test.c. It has command "true" and
> "false". Shall I undef true and false before the U_BOOT_CMD
> in this file, or use True and False as the names? If there is
> a better way to do that, please enlighten me.
>
> York
If you rename commands "true" and "false" to "True" and "False"
you will break all code which using it. Now RX-51 board do not
booting due to missing "true" and "false" commands...
--
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130404/c3b3b8e6/attachment-0001.pgp>
next prev parent reply other threads:[~2013-04-04 21:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 17:46 [U-Boot] [PATCH] CRITICAL error in v2013.04-rc2 (true and false not working) Pali Rohár
2013-04-04 20:33 ` Wolfgang Denk
2013-04-04 20:34 ` York Sun
2013-04-04 21:05 ` York Sun
2013-04-04 21:19 ` Pali Rohár [this message]
2013-04-04 21:21 ` York Sun
2013-04-04 21:26 ` Pali Rohár
2013-04-04 21:31 ` York Sun
2013-04-04 21:50 ` Wolfgang Denk
2013-04-04 21:58 ` York Sun
2013-04-04 21:47 ` Wolfgang Denk
2013-04-04 21:48 ` York Sun
2013-04-04 21:37 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304042319.39473@pali \
--to=pali.rohar@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox