From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [v3] command/cache: Add flush command
Date: Mon, 08 Apr 2013 20:35:13 +0200 [thread overview]
Message-ID: <20130408183513.D80752016C2@gemini.denx.de> (raw)
In-Reply-To: <C707E9F4D8007146BF8DC1424B113AC70B3A6A83@039-SN2MPN1-012.039d.mgd.msft.net>
Dear sun york-R58495,
In message <C707E9F4D8007146BF8DC1424B113AC70B3A6A83@039-SN2MPN1-012.039d.mgd.msft.net> you wrote:
>
> I think it is best to keep this patch as it and stick with the
> original flush_cache name. It uses the existing function
> flush_cache() which is available for most (if not all) architectures.
> Splitting the dcache and icache not only adds more code, but
> architecture-dependent code.
As mentioned before: reusing existing code is fine, but we already
have commands for cache handling, and adding arbitrary new ones to
implement combinations of functions makes does not scale. Assume
tomorrow someone needs to add more ganular handling for example
regarding L2 caches, etc. Would you suggest to add another set of new
commands, then? This makes no sense.
Please implement IC related operations as subcommands to the "icache"
command, and DC releated ones as subcommands to "dcache".
[In the example of L2 cache above, it would be for example sufficient
to add a "-L2" option to the "icache" / "dcache" commands.]
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A man either lives life as it happens to him, meets it head-on and
licks it, or he turns his back on it and starts to wither away.
-- Dr. Boyce, "The Menagerie" ("The Cage"), stardate unknown
next prev parent reply other threads:[~2013-04-08 18:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 20:50 [U-Boot] [v3] command/cache: Add flush command York Sun
2013-04-05 21:00 ` Tom Rini
2013-04-05 21:09 ` York Sun
2013-04-05 22:09 ` Wolfgang Denk
2013-04-05 23:02 ` York Sun
2013-04-06 7:01 ` Wolfgang Denk
2013-04-07 3:31 ` sun york-R58495
2013-04-07 8:29 ` Wolfgang Denk
2013-04-08 17:45 ` sun york-R58495
2013-04-08 18:35 ` Wolfgang Denk [this message]
2013-04-08 19:05 ` Scott Wood
2013-04-08 19:18 ` Wolfgang Denk
2013-04-08 19:31 ` Scott Wood
2013-04-09 17:45 ` Wolfgang Denk
2013-04-10 0:58 ` Scott Wood
2013-04-10 2:07 ` [U-Boot] DWMMC / DWMCI question TigerLiu at viatech.com.cn
2013-04-10 11:58 ` Wolfgang Denk
2013-04-11 1:43 ` TigerLiu at viatech.com.cn
2013-04-10 11:54 ` [U-Boot] [v3] command/cache: Add flush command Wolfgang Denk
2013-04-10 19:42 ` Scott Wood
2013-04-10 21:04 ` Wolfgang Denk
2013-04-10 21:10 ` Scott Wood
2013-04-10 22:50 ` Wolfgang Denk
2013-04-10 23:00 ` Scott Wood
2013-04-11 11:56 ` Wolfgang Denk
2013-04-08 19:50 ` Scott Wood
2013-04-09 17:48 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130408183513.D80752016C2@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox