From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Tue, 9 Apr 2013 16:11:32 +0200 Subject: [U-Boot] [U-Boot, 1/4] cam_enc_4xx: fix CONFIG_SPL_MAX_SIZE semantics In-Reply-To: <516414CE.3060007@denx.de> References: <1365451109-22030-2-git-send-email-albert.u.boot@aribaud.net> <20130408204353.GP5729@bill-the-cat> <5163BA32.2020702@denx.de> <20130409110808.166e7413@lilith> <5164057A.4010306@denx.de> <20130409144221.20bc6503@lilith> <516414CE.3060007@denx.de> Message-ID: <20130409161132.27ae7d43@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Heiko, On Tue, 09 Apr 2013 15:17:02 +0200, Heiko Schocher wrote: > Hello Albert, > > on 09.04.2013 14:42, wrote Albert ARIBAUD: > > Hi Heiko, > > > > On Tue, 09 Apr 2013 14:11:38 +0200, Heiko Schocher wrote: > > > >>> Let us assume I keep 12K. Here is a current build of cam_enc_4xx: > >>> > >>> text data bss dec hex filename > >>> 439526 13148 311092 763766 ba776 ./u-boot > >>> 9073 840 500 10413 28ad ./spl/u-boot-spl > [...] > >>> Would that be ok? > >> > >> Yes, that seems good to me, but I could not test it ... > > > > I can do a diff of the binaries with and without the patch -- > > normally, they should be the same except for the U-Boot version > > identification. Would that do? > > Yes. I did this too, and see only a diff for the version string. Thanks -- I've staged the 10K+2K change for V2. > (But not forget to commit your change first, else the "-dirty" > in the version string will insert an offset ;-) I actually keep a 'fake_build' branch with a single nifty commit on it that makes almost all version information sources constant (only mkimage resists as it collects the current date and time programmatically, but that's ok, I don't aim for 100% faking. So, whenever I need to do bulk comparisons, I add this commit above the two branches to be compared, and two batch builds later, I can compare the .bins, even if different commit ID and/or local changes are involved. :) > bye, > Heiko Amicalement, -- Albert.