From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Tue, 9 Apr 2013 16:23:58 +0200 Subject: [U-Boot] [PATCH 4/4] ARM: fix CONFIG_SPL_MAX_SIZE semantics In-Reply-To: <626694845.1367591.1365457417729.JavaMail.root@advansee.com> References: <1365451109-22030-1-git-send-email-albert.u.boot@aribaud.net> <1365451109-22030-2-git-send-email-albert.u.boot@aribaud.net> <1365451109-22030-3-git-send-email-albert.u.boot@aribaud.net> <1365451109-22030-4-git-send-email-albert.u.boot@aribaud.net> <1365451109-22030-5-git-send-email-albert.u.boot@aribaud.net> <626694845.1367591.1365457417729.JavaMail.root@advansee.com> Message-ID: <20130409162358.2e110964@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Beno?t, On Mon, 8 Apr 2013 23:43:37 +0200 (CEST), Beno?t Th?baudeau wrote: > Hi Albert, > > diff --git a/arch/arm/cpu/u-boot-spl.lds b/arch/arm/cpu/u-boot-spl.lds > > index 3c0d99c..89ef9ce 100644 > > --- a/arch/arm/cpu/u-boot-spl.lds > > +++ b/arch/arm/cpu/u-boot-spl.lds > > @@ -88,6 +88,12 @@ SECTIONS > > /DISCARD/ : { *(.gnu*) } > > } > > > > -#if defined(CONFIG_SPL_TEXT_BASE) && defined(CONFIG_SPL_MAX_SIZE) > > -ASSERT(__bss_end < (CONFIG_SPL_TEXT_BASE + CONFIG_SPL_MAX_SIZE), "SPL image > > too big"); > > +#if defined(CONFIG_SPL_MAX_SIZE) > > +ASSERT(__image_copy_end - __image_copy_start < (CONFIG_SPL_MAX_SIZE), \ > > The possible relocation and MMU data is also part of the binary image file, so > that would be __bss_start rather than __image_copy_end above, and README should > be updated to reflect this. Actually, mmutable is not used in any SPL; it is used only in targets h2200, lubbock, palmtc, pxa255_idp and xaeniax, none of which use SPL. I have just confirmed this with a MAKEALL -a arm and a grep on all map files. This presence of mmutable in u-boot-spl.lds is in fact an overlook that I missed when I created this file from u-boot.lds. I have just finished verifying that removing the mmutable section altogether does not change a single bit to any of the 309 ARM platforms currently built under MAKEALL -a arm. I'll remove mmutable entries from u-boot-spl.lds in V2. Amicalement, -- Albert.