public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx28evk: add trimffs to nand command
Date: Tue, 9 Apr 2013 21:21:44 +0200	[thread overview]
Message-ID: <20130409212144.1c86b16e@e6520eb> (raw)
In-Reply-To: <516457C4.7050809@freescale.com>

Hi Fabio,

Le Tue, 9 Apr 2013 15:02:44 -0300,
Fabio Estevam <fabio.estevam@freescale.com> a ?crit :

> Eric B?nard wrote:
> > this is usefull when writing an UBI image which contains
> > and UBIFS volume (check README.nand and UBI FAQ for more details)
> > 
> > Signed-off-by: Eric B?nard <eric@eukrea.com>
> > ---
> >  include/configs/mx28evk.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
> > index d470b47..b22a20b 100644
> > --- a/include/configs/mx28evk.h
> > +++ b/include/configs/mx28evk.h
> > @@ -63,6 +63,7 @@
> >  #define CONFIG_CMD_USB
> >  #define CONFIG_CMD_BOOTZ
> >  #define CONFIG_CMD_NAND
> > +#define CONFIG_CMD_NAND_TRIMFFS
> 
> You should add this into mx28evk_nand.h, available in u-boot.imx tree.

that's the second time you ask this but mx28evk_nand.h doesn't exist,
even in u-boot-imx tree, and you are the developer who added nand
support to mx28evk in commit
ab461be65dbfe3e2fa45f7cd836faa99663be5bb ;-)

Here is a reminder of what you did in that commit : you added the
mx28evk_nand option in boards.cfg which defines ENV_IS_IN_NAND when
mx28evk defines ENV_IS_IN_MMC and both are using the same config which
is include/configs/mx28evk.h :
http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=ab461be65dbfe3e2fa45f7cd836faa99663be5bb

So this patch is fine against u-boot-imx.

Best regards
Eric

  reply	other threads:[~2013-04-09 19:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08 18:59 [U-Boot] [PATCH] mx28evk: add trimffs to nand command Eric Bénard
2013-04-09 17:35 ` Otavio Salvador
2013-04-09 18:02 ` Fabio Estevam
2013-04-09 19:21   ` Eric Bénard [this message]
2013-04-09 20:04     ` Fabio Estevam
2013-04-16 11:02 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130409212144.1c86b16e@e6520eb \
    --to=eric@eukrea.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox