From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v6, 4/9] nand: Extend nand_(read|write)_skip_bad with *actual and limit parameters
Date: Wed, 10 Apr 2013 09:08:19 -0400 [thread overview]
Message-ID: <20130410130819.GR5729@bill-the-cat> (raw)
In-Reply-To: <1363275175-8408-5-git-send-email-trini@ti.com>
On Thu, Mar 14, 2013 at 05:32:50AM -0000, Tom Rini wrote:
> We make these two functions take a size_t pointer to how much space
> was used on NAND to read or write the buffer (when reads/writes happen)
> so that bad blocks can be accounted for. We also make them take an
> loff_t limit on how much data can be read or written. This means that
> we can now catch the case of when writing to a partition would exceed
> the partition size due to bad blocks. To do this we also need to make
> check_skip_len count not just complete blocks used but partial ones as
> well. All callers of nand_(read|write)_skip_bad are adjusted to call
> these with the most sensible limits available.
>
> The changes were started by Pantelis and finished by Tom.
>
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> Signed-off-by: Tom Rini <trini@ti.com>
With current master, the following changes are needed to adapt cm_t35 to
these call changes:
diff --git a/board/cm_t35/cm_t35.c b/board/cm_t35/cm_t35.c
index 629ce4a..84c36ba 100644
--- a/board/cm_t35/cm_t35.c
+++ b/board/cm_t35/cm_t35.c
@@ -91,6 +91,7 @@ static int splash_load_from_nand(u32 bmp_load_addr)
res = nand_read_skip_bad(&nand_info[nand_curr_device],
splash_screen_nand_offset, &bmp_header_size,
+ NULL, nand_info[nand_curr_device].size,
(u_char *)bmp_load_addr);
if (res < 0)
return res;
@@ -103,6 +104,7 @@ static int splash_load_from_nand(u32 bmp_load_addr)
return nand_read_skip_bad(&nand_info[nand_curr_device],
splash_screen_nand_offset, &bmp_size,
+ NULL, nand_info[nand_curr_device].size,
(u_char *)bmp_load_addr);
splash_address_too_high:
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130410/f7f4e395/attachment.pgp>
next prev parent reply other threads:[~2013-04-10 13:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 15:32 [U-Boot] [PATCH v6 0/9] Improve DFU support, enable for am335x_evm Tom Rini
2013-03-14 15:32 ` [U-Boot] [PATCH v6 1/9] README: Document current DFU CONFIG options Tom Rini
2013-03-14 15:32 ` [U-Boot] [PATCH v6 2/9] dfu: Support larger than memory transfers Tom Rini
2013-03-14 15:32 ` [U-Boot] [PATCH v6 3/9] dfu: Change indentation of defines in <dfu.h> Tom Rini
2013-03-14 15:32 ` [U-Boot] [PATCH v6 4/9] nand: Extend nand_(read|write)_skip_bad with *actual and limit parameters Tom Rini
2013-04-10 13:08 ` Tom Rini [this message]
2013-04-11 6:37 ` [U-Boot] [U-Boot, v6, " Igor Grinberg
2013-04-11 12:07 ` Tom Rini
2013-03-14 15:32 ` [U-Boot] [PATCH v6 5/9] cmd_nand.c: Fix CONFIG_CMD_NAND_YAFFS Tom Rini
2013-03-14 17:32 ` Scott Wood
2013-03-14 15:32 ` [U-Boot] [PATCH v6 6/9] dfu: NAND specific routines for DFU operation Tom Rini
2013-03-14 17:32 ` Scott Wood
2013-03-14 15:32 ` [U-Boot] [PATCH v6 7/9] am335x_evm: Define CONFIG_SYS_CACHELINE_SIZE Tom Rini
2013-03-14 15:32 ` [U-Boot] [PATCH v6 8/9] am335x_evm: Add CONFIG_CMD_MTDPARTS and relevant defaults Tom Rini
2013-03-14 15:32 ` [U-Boot] [PATCH v6 9/9] am335x_evm: Enable DFU for NAND and MMC, provide example alt_infos Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410130819.GR5729@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox