From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 10 Apr 2013 16:11:40 -0400 Subject: [U-Boot] [PATCH 1/1] powerpc/lib: fix unsafe register handling in wait_ticks Message-ID: <20130410201140.GF9914@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Apr 09, 2013 at 05:10:59PM +0200, Mats K??rrman wrote: > If watchdog is enabled, the arch/powerpc/lib/ticks.S::wait_ticks() function > calls the function specified by the WATCHDOG_RESET macro. > The wait_ticks function depends on the registers r0, r6 and r7 being > preserved however that is not guaranteed, e.g. if the reset function is a > C function this will probably overwrite r0 and cause an endless loop. > > The following patch changes to using r14+r15 instead of r6+r7 (to resemble > what would have been generated by a C compiler) and saves all necessary > registers on the stack. > > The patch has been tested on a custom MPC5125 based machine using the 512x > powerpc architecture. > > Signed-off-by: Mats Karrman > Cc: Wolfgang Denk > Acked-by: Joakim Tjernlund > Tested-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: