[U-Boot] Please pull u-boot-ti/master

Yegor Yefremov
2013-12-06T10:11:05Z

On Fri, Dec 6, 2013 at 11:08 AM, Stefan Roese <sr@denx.de> wrote:
> Hi Yegor,
>
> On 06.12.2013 10:20, Yegor Yefremov wrote:
>>> This causes am3517_evm to fail with warnings:
>>>
>>> am3517evm.c: In function 'misc_init_r':
>>> am3517evm.c:106:6: warning: unused variable 'reset' [-Wunused-variable]
>>> am3517evm.c:105:24: warning: unused variable 'ctr' [-Wunused-variable]
>>> am3517evm.c: In function 'misc_init_r':
>>> am3517evm.c:106:6: warning: unused variable 'reset' [-Wunused-variable]
>>> am3517evm.c:105:24: warning: unused variable 'ctr' [-Wunused-variable]
>>>
>>> These are trivial, but I'd like them fixed; lingering warnings are a
>>> pain to manage when doing large-scale test build.
>>>
>>> These ones come from commit ae98bbeb, that is :
>>>
>>>> Yegor Yefremov (1):
>>>> am3517_evm: activate Ethernet PHY
>>>
>>> Yegor, can you fix this? Thanks.
>>
>> v2 sent. I've put those variables under if defined statement, so the
>> warning has gone.
>
> In general its preferred to use the __maybe_unused statement instead of
> adding more #ifdef's. Like this:
>
> + __maybe_unused volatile unsigned int ctr;
> + __maybe_unused u32 reset;
>
> Care to send a v3 for this patch?

Will do.

Yegor