From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Thu, 11 Apr 2013 01:09:54 +0200 Subject: [U-Boot] [PATCH v2 4/4] ARM: fix CONFIG_SPL_MAX_SIZE semantics In-Reply-To: <20130411005001.56efc6a3@lilith> References: <1365451109-22030-1-git-send-email-albert.u.boot@aribaud.net> <1365549295-9388-1-git-send-email-albert.u.boot@aribaud.net> <1365549295-9388-2-git-send-email-albert.u.boot@aribaud.net> <1365549295-9388-3-git-send-email-albert.u.boot@aribaud.net> <1365549295-9388-4-git-send-email-albert.u.boot@aribaud.net> <1365549295-9388-5-git-send-email-albert.u.boot@aribaud.net> <5165E602.5040700@wwwdotorg.org> <20130411005001.56efc6a3@lilith> Message-ID: <20130411010954.2fc374de@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 11 Apr 2013 00:50:01 +0200, Albert ARIBAUD wrote: > What we could do, though, is subdivide testing based on the existence or > non-existence of CONFIG_SPL_BSS_START_ADDR: > > - if CONFIG_SPL_BSS_START_ADDR exists, then we assume SPL image and > BSS are disjoint and we test each one against its max size, as this > patch series does; > > - if CONFIG_SPL_BSS_START_ADDR does not exist, then we assume SPL image > and BSS are contiguous and we test the whole of SPL against the sum > of CONFIG_SPL_MAX_SIZE and CONFIG_SPL_BSS_MAX_SIZE. > > I guess this will be considered useless complication -- after all, > once you have artificially partitioned your SPL space into image+BSS -- > and you know from the build command how much should be allotted to each > of them -- the worst that can happen is that a later build fails with > an explicit error message forcing you to look at current image and BSS > size and adjust one or both of the max values accordingly. P.S. In any case, the proposal above will go in, if at all, as a separate patch; the current patch series is going in right now as it is. Amicalement, -- Albert.