[U-Boot] [PATCH v2 4/4] ARM: fix CONFIG_SPL_MAX_SIZE semantics

Stephen Warren
2013-04-10T23:16:49Z

On 04/10/2013 05:09 PM, Albert ARIBAUD wrote:
> On Thu, 11 Apr 2013 00:50:01 +0200, Albert ARIBAUD
> <albert.u.boot@aribaud.net> wrote:
>
>> What we could do, though, is subdivide testing based on the existence or
>> non-existence of CONFIG_SPL_BSS_START_ADDR:
>>
>> - if CONFIG_SPL_BSS_START_ADDR exists, then we assume SPL image and
>> BSS are disjoint and we test each one against its max size, as this
>> patch series does;
>>
>> - if CONFIG_SPL_BSS_START_ADDR does not exist, then we assume SPL image
>> and BSS are contiguous and we test the whole of SPL against the sum
>> of CONFIG_SPL_MAX_SIZE and CONFIG_SPL_BSS_MAX_SIZE.
>>
>> I guess this will be considered useless complication -- after all,
>> once you have artificially partitioned your SPL space into image+BSS --
>> and you know from the build command how much should be allotted to each
>> of them -- the worst that can happen is that a later build fails with
>> an explicit error message forcing you to look at current image and BSS
>> size and adjust one or both of the max values accordingly.
>
> P.S. In any case, the proposal above will go in, if at all, as a
> separate patch; the current patch series is going in right now as it is.

I wonder what the point of code-review is if you're just going to ignore it.

What's really odd here is that by my reading of the relevant threads,
TomR already pointed out this exact issue earlier on, and you had agreed
that you'd resolve it in a way that didn't have this issue, yet the
patch has this issue???