[U-Boot] [PATCH v2 3/4] smdk5250, snow: fix CONFIG_SPL_MAX_SIZE semantics

Minkyu Kang
2013-04-10T02:01:01Z

On 10/04/13 08:14, Albert ARIBAUD wrote:
> CONFIG_SPL_MAX_SIZE wrongly included BSS size.
> Split 14K max size between 10K image (text,rodata,data)
> and 4K BSS based on sizes reported for current build:
>
> text data bss
> 4136 904 0
>
> Signed-off-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
> Changes in v2:
> - fixed spacing in commit summary
>
> board/samsung/smdk5250/smdk5250-uboot-spl.lds | 2 +-
> include/configs/exynos5250-dt.h | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/board/samsung/smdk5250/smdk5250-uboot-spl.lds b/board/samsung/smdk5250/smdk5250-uboot-spl.lds
> index 4c8baaa..208e626 100644
> --- a/board/samsung/smdk5250/smdk5250-uboot-spl.lds
> +++ b/board/samsung/smdk5250/smdk5250-uboot-spl.lds
> @@ -26,7 +26,7 @@
> */
>
> MEMORY { .sram : ORIGIN = CONFIG_SPL_TEXT_BASE, \
> - LENGTH = CONFIG_SPL_MAX_SIZE }
> + LENGTH = (CONFIG_SPL_MAX_SIZE + CONFIG_SPL_BSS_MAX_SIZE) }
>
> OUTPUT_FORMAT("elf32-littlearm", "elf32-littlearm", "elf32-littlearm")
> OUTPUT_ARCH(arm)
> diff --git a/include/configs/exynos5250-dt.h b/include/configs/exynos5250-dt.h
> index 496a194..372b0b4 100644
> --- a/include/configs/exynos5250-dt.h
> +++ b/include/configs/exynos5250-dt.h
> @@ -141,7 +141,8 @@
> /* specific .lds file */
> #define CONFIG_SPL_LDSCRIPT "board/samsung/smdk5250/smdk5250-uboot-spl.lds"
> #define CONFIG_SPL_TEXT_BASE 0x02023400
> -#define CONFIG_SPL_MAX_SIZE (14 * 1024)
> +#define CONFIG_SPL_MAX_SIZE (10 * 1024)
> +#define CONFIG_SPL_BSS_MAX_SIZE (4 * 1024)
>
> #define CONFIG_BOOTCOMMAND "mmc read 40007000 451 2000; bootm 40007000"
>
>

Acked-by: Minkyu Kang <mk7.kang@samsung.com>

Thanks,
Minkyu Kang.