From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/7] pxa27x_udc: remove call to unimplemented set_GPIO_mode()
Date: Thu, 11 Apr 2013 21:16:53 +0200 [thread overview]
Message-ID: <201304112116.53424.marex@denx.de> (raw)
In-Reply-To: <1365641128-15812-4-git-send-email-mikedunn@newsguy.com>
Dear Mike Dunn,
> If CONFIG_USB_DEV_PULLUP_GPIO is defined, a link error occurs because the
> set_GPIO_mode() helper function is not implemented. This function doesn't
> do much except make the code a little more readable, so I just manually
> coded its equivalent and removed the prototype from the header file. It
> is invoked no where else in the code.
>
> While I was at it, I noticed that two other function prototypes in the same
> header file are also neither implemented nor invoked anywhere, so I removed
> them as well.
>
> Signed-off-by: Mike Dunn <mikedunn@newsguy.com>
Reviewed-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-04-11 19:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 0:45 [U-Boot] [PATCH v2 0/7] palm treo 680 smartphone board support Mike Dunn
2013-04-11 0:45 ` [U-Boot] [PATCH v2 1/7] pxa_lcd: add the ACX544AKN lcd device Mike Dunn
2013-04-11 19:14 ` Marek Vasut
2013-04-11 0:45 ` [U-Boot] [PATCH v2 2/7] pxa_lcd: make lcd_enable() a weak pointer Mike Dunn
2013-04-11 19:15 ` Marek Vasut
2013-04-11 0:45 ` [U-Boot] [PATCH v2 3/7] pxa27x_udc: remove call to unimplemented set_GPIO_mode() Mike Dunn
2013-04-11 19:16 ` Marek Vasut [this message]
2013-04-11 0:45 ` [U-Boot] [PATCH v2 4/7] arm: bootm: call udc_disable()before booting linux Mike Dunn
2013-04-11 19:18 ` Marek Vasut
2013-04-11 0:45 ` [U-Boot] [PATCH v2 5/7] lib: import bitrev library from the linux kernel Mike Dunn
2013-04-11 19:19 ` Marek Vasut
2013-04-12 12:01 ` Mike Dunn
2013-04-12 17:28 ` Marek Vasut
2013-04-13 19:27 ` Wolfgang Denk
2013-04-11 0:45 ` [U-Boot] [PATCH v2 6/7] mtd: nand: add driver for diskonchip g4 nand flash Mike Dunn
2013-04-11 19:19 ` Marek Vasut
2013-04-12 16:29 ` Scott Wood
2013-04-11 21:00 ` Scott Wood
2013-04-12 13:36 ` Mike Dunn
2013-04-12 17:27 ` Marek Vasut
2013-04-12 17:34 ` Scott Wood
2013-04-11 0:45 ` [U-Boot] [PATCH v2 7/7] add support for palm treo 680 board Mike Dunn
2013-04-11 19:20 ` Marek Vasut
2013-04-12 12:51 ` Mike Dunn
2013-04-12 17:26 ` Marek Vasut
2013-04-14 17:44 ` [U-Boot] [PATCH v2 0/7] palm treo 680 smartphone board support Marek Vasut
2013-04-14 20:10 ` Mike Dunn
2013-04-14 20:13 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304112116.53424.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox