From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 5/7] lib: import bitrev library from the linux kernel
Date: Fri, 12 Apr 2013 19:28:20 +0200 [thread overview]
Message-ID: <201304121928.20635.marex@denx.de> (raw)
In-Reply-To: <5167F7B4.3070007@newsguy.com>
Dear Mike Dunn,
> On 04/11/2013 12:19 PM, Marek Vasut wrote:
> > Dear Mike Dunn,
> >
> >> This patch adds the bitrev library from the linux kernel. This is a
> >> simple algorithm that uses an 8 bit look-up table to reverse the bits
> >> in data types of 8, 16, or 32 bit widths. The docg4 nand flash driver
> >> uses it.
> >>
> >> [port from linux kernel 2.6.20 commit
> >> a5cfc1ec58a07074dacb6aa8c79eff864c966d12]
> >
> > Why did you port it from such an ancient kernel? Newer version is not an
> > option?
>
> Maybe I misunderstood and gave the wrong information (probably, now that I
> think about it). I took it fom the latest kernel, but reported the commit
> that added it to the kernel.
>
> In this case, it's a simple algorithm and only a couple trivial changes
> were made since it was first added to the kernel, so the error is probably
> inconsequential, but I'll resubmit, reporting the HEAD of the kernel I
> took it from if you like.
>
> BTW, I did the same for the docg4 driver, but I did the u-boot port a while
> ago, so in that case it's correct, at least practically. Since I did the
> port, the kernel docg4 driver had some enhancements (reliable mode) that
Knowing which tag in linux-stable you pulled it from is a good information too,
yes.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-04-12 17:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 0:45 [U-Boot] [PATCH v2 0/7] palm treo 680 smartphone board support Mike Dunn
2013-04-11 0:45 ` [U-Boot] [PATCH v2 1/7] pxa_lcd: add the ACX544AKN lcd device Mike Dunn
2013-04-11 19:14 ` Marek Vasut
2013-04-11 0:45 ` [U-Boot] [PATCH v2 2/7] pxa_lcd: make lcd_enable() a weak pointer Mike Dunn
2013-04-11 19:15 ` Marek Vasut
2013-04-11 0:45 ` [U-Boot] [PATCH v2 3/7] pxa27x_udc: remove call to unimplemented set_GPIO_mode() Mike Dunn
2013-04-11 19:16 ` Marek Vasut
2013-04-11 0:45 ` [U-Boot] [PATCH v2 4/7] arm: bootm: call udc_disable()before booting linux Mike Dunn
2013-04-11 19:18 ` Marek Vasut
2013-04-11 0:45 ` [U-Boot] [PATCH v2 5/7] lib: import bitrev library from the linux kernel Mike Dunn
2013-04-11 19:19 ` Marek Vasut
2013-04-12 12:01 ` Mike Dunn
2013-04-12 17:28 ` Marek Vasut [this message]
2013-04-13 19:27 ` Wolfgang Denk
2013-04-11 0:45 ` [U-Boot] [PATCH v2 6/7] mtd: nand: add driver for diskonchip g4 nand flash Mike Dunn
2013-04-11 19:19 ` Marek Vasut
2013-04-12 16:29 ` Scott Wood
2013-04-11 21:00 ` Scott Wood
2013-04-12 13:36 ` Mike Dunn
2013-04-12 17:27 ` Marek Vasut
2013-04-12 17:34 ` Scott Wood
2013-04-11 0:45 ` [U-Boot] [PATCH v2 7/7] add support for palm treo 680 board Mike Dunn
2013-04-11 19:20 ` Marek Vasut
2013-04-12 12:51 ` Mike Dunn
2013-04-12 17:26 ` Marek Vasut
2013-04-14 17:44 ` [U-Boot] [PATCH v2 0/7] palm treo 680 smartphone board support Marek Vasut
2013-04-14 20:10 ` Mike Dunn
2013-04-14 20:13 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304121928.20635.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox