From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 12 Apr 2013 19:28:20 +0200 Subject: [U-Boot] [PATCH v2 5/7] lib: import bitrev library from the linux kernel In-Reply-To: <5167F7B4.3070007@newsguy.com> References: <1365641128-15812-1-git-send-email-mikedunn@newsguy.com> <201304112119.05640.marex@denx.de> <5167F7B4.3070007@newsguy.com> Message-ID: <201304121928.20635.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Mike Dunn, > On 04/11/2013 12:19 PM, Marek Vasut wrote: > > Dear Mike Dunn, > > > >> This patch adds the bitrev library from the linux kernel. This is a > >> simple algorithm that uses an 8 bit look-up table to reverse the bits > >> in data types of 8, 16, or 32 bit widths. The docg4 nand flash driver > >> uses it. > >> > >> [port from linux kernel 2.6.20 commit > >> a5cfc1ec58a07074dacb6aa8c79eff864c966d12] > > > > Why did you port it from such an ancient kernel? Newer version is not an > > option? > > Maybe I misunderstood and gave the wrong information (probably, now that I > think about it). I took it fom the latest kernel, but reported the commit > that added it to the kernel. > > In this case, it's a simple algorithm and only a couple trivial changes > were made since it was first added to the kernel, so the error is probably > inconsequential, but I'll resubmit, reporting the HEAD of the kernel I > took it from if you like. > > BTW, I did the same for the docg4 driver, but I did the u-boot port a while > ago, so in that case it's correct, at least practically. Since I did the > port, the kernel docg4 driver had some enhancements (reliable mode) that Knowing which tag in linux-stable you pulled it from is a good information too, yes. Best regards, Marek Vasut