public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARMv7: start.S: stay in HYP mode if u-boot is entered in it
Date: Mon, 15 Apr 2013 19:20:54 +0200	[thread overview]
Message-ID: <20130415192054.16159abf@lilith> (raw)
In-Reply-To: <1364917416-11147-1-git-send-email-andre.przywara@linaro.org>

Hi Andre,

On Tue,  2 Apr 2013 17:43:36 +0200, Andre Przywara
<andre.przywara@linaro.org> wrote:

> The KVM and Xen hypervisors for the Cortex-A15 virtualization
> implementation need to be entered in HYP mode. Should the primary
> board firmware already enter HYP mode (Calxeda firmware does that),
> we should not deliberately drop back to SVC mode.
> Since U-boot does not use the MMU, running in HYP mode is just fine.
> 
> Signed-off-by: Andre Przywara <andre.przywara@linaro.org>
> ---
>  arch/arm/cpu/armv7/start.S | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S
> index 36a4c3c..95c8a95 100644
> --- a/arch/arm/cpu/armv7/start.S
> +++ b/arch/arm/cpu/armv7/start.S
> @@ -126,11 +126,15 @@ IRQ_STACK_START_IN:
>  reset:
>  	bl	save_boot_params
>  	/*
> -	 * set the cpu to SVC32 mode
> +	 * disable interrupts (FIQ and IRQ), also set the cpu to SVC32 mode,
> +	 * except if in HYP mode already
>  	 */
>  	mrs	r0, cpsr
> -	bic	r0, r0, #0x1f
> -	orr	r0, r0, #0xd3
> +	and	r1, r0, #0x1f		@ mask mode bits
> +	teq	r1, #0x1a		@ test for HYP mode
> +	bicne	r0, r0, #0x1f		@ clear all mode bits
> +	orrne	r0, r0, #0x13		@ set SVC mode
> +	orr	r0, r0, #0xc0		@ disable FIQ and IRQ
>  	msr	cpsr,r0
>  
>  /*

Applied to u-boot-arm/master, thanks!

Amicalement,
-- 
Albert.

      reply	other threads:[~2013-04-15 17:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-02 15:43 [U-Boot] [PATCH] ARMv7: start.S: stay in HYP mode if u-boot is entered in it Andre Przywara
2013-04-15 17:20 ` Albert ARIBAUD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130415192054.16159abf@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox