From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 18 Apr 2013 15:54:14 +0200
Subject: [U-Boot] [PATCH v4] palmtreo680: add utility that writes u-boot
	to flash
In-Reply-To: <1366143307-7055-1-git-send-email-mikedunn@newsguy.com>
References: <1366143307-7055-1-git-send-email-mikedunn@newsguy.com>
Message-ID: <201304181554.15041.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Mike Dunn,

[...]

> +	if (argc != 3) {
> +		printf("usage: %s <image file> <mtd dev node>\n", argv[0]);

btw is this /dev/mtdX or /dev/mtdblockX ?

> +		return -1;

errno.h didn't work? Like ... return -EINVAL or such ?

[...]

> +	blockbuf = calloc(RELIABLE_BLOCKSIZE, 1);

calloc() semantics are misunderstood by so many :-(

[...]

Best regards,
Marek Vasut