From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric =?UTF-8?B?QsOpbmFyZA==?= <eric@eukrea.com>
Date: Fri, 19 Apr 2013 10:27:17 +0200
Subject: [U-Boot] [PATCH] imx: Add support for the SabreSD shipped with
 i.MX6DL
In-Reply-To: <5170FD35.7050700@denx.de>
References: <1366296086-22394-1-git-send-email-p.aubert@staubli.com>
	<20130418173739.88D9A20019A@gemini.denx.de>
	<5170FD35.7050700@denx.de>
Message-ID: <20130419102717.71299343@e6520eb>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stefano,

Le Fri, 19 Apr 2013 10:15:49 +0200,
Stefano Babic <sbabic@denx.de> a ?crit :

> On 18/04/2013 19:37, Wolfgang Denk wrote:
> > Dear Pierre Aubert,
> > 
> > In message <1366296086-22394-1-git-send-email-p.aubert@staubli.com> you wrote:
> >> The SabreSD platform is available with i.MX6Q or i.MX6DL. This patch adds the
> >> support of the i.MX6DL. The config file and the board directory are renamed
> >> to remove the reference to the MX6Q.
> > 
> > Formal issues:
> > 
> > - entry to MAINTAINERS file missing
> > - there are 2 checkpatch warnings ("please, no spaces at the start of
> >   a line") that need to be fixed.
> > 
> >>  int checkboard(void)
> >>  {
> >> -	puts("Board: MX6Q-SabreSD\n");
> >> -
> >> +#ifdef CONFIG_MX6Q
> >> +    puts("Board: MX6Q-SabreSD\n");
> >> +#else
> >> +    puts("Board: MX6DL-SabreSD\n");
> >> +#endif
> > 
> > Can we please avoid such #ifdef's?  Here, we could for example refer
> > to the board name (CONFIG_SYS_BOARD if you like the name, or some
> > custom defined CONFIG_BOARD_NAME like other boards do).
> 
> And who does set CONFIG_MX6Q ? You drop it, but I do not see who sets it.
> 
that's done in boards.cfg :
+++ b/boards.cfg
+mx6qsabreauto                arm         armv7	mx6qsabreauto       freescale      mx6 mx6qsabreauto:IMX_CONFIG=board/freescale/mx6qsabreauto/imximage.cfg,MX6Q

Eric