From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/6] arm: mx5: Add support for DENX M53EVK
Date: Fri, 19 Apr 2013 14:58:36 +0200 [thread overview]
Message-ID: <20130419125836.69EC2200566@gemini.denx.de> (raw)
In-Reply-To: <201304191358.25181.marex@denx.de>
Dear Marek Vasut,
In message <201304191358.25181.marex@denx.de> you wrote:
>
> > > +#define CONFIG_LOADADDR 0x70800000
> > > +#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
> >
> > What do we need CONFIG_LOADADDR for?
>
> For this stuff, the "loadaddr" env variable. I have kinda idea to kill this and
> unify it to CONFIG_SYS_LOAD_ADDR all around, what do you think?
Why CONFIG_SYS_* ?
> include/env_default.h:#ifdef CONFIG_LOADADDR
> include/env_default.h: "loadaddr=" __stringify(CONFIG_LOADADDR) "\0"
Indeed - I missed this one. I only checked C and asm sources, and
cound not find a single reference...
So arch/blackfin/include/asm/config.h and include/env_default.h are
the only locateions that refer to CONFIG_LOADADDR ? This should
indeed be cleaned up. [But this is not related to your patch any
longer.]
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If something is different, it's either better or worse, and usually
both. - Larry Wall
next prev parent reply other threads:[~2013-04-19 12:58 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 4:10 [U-Boot] [PATCH 1/6] imx: Align the imximage header and payload to multiples of 4k Marek Vasut
2013-04-19 4:10 ` [U-Boot] [PATCH 2/6] nand: Add SPL_NAND support to mxc_nand_spl Marek Vasut
2013-04-19 8:38 ` Benoît Thébaudeau
2013-04-19 9:35 ` Benoît Thébaudeau
2013-04-19 11:14 ` Marek Vasut
2013-04-19 11:55 ` Benoît Thébaudeau
2013-04-19 13:46 ` Benoît Thébaudeau
2013-04-19 17:08 ` Marek Vasut
2013-04-20 13:00 ` Benoît Thébaudeau
2013-04-19 17:06 ` Marek Vasut
2013-04-20 13:06 ` Benoît Thébaudeau
2013-04-20 17:09 ` Marek Vasut
2013-04-19 13:00 ` Philip Paeps
2013-04-19 14:48 ` Philip Paeps
2013-04-19 14:53 ` Benoît Thébaudeau
2013-04-19 15:09 ` Philip Paeps
2013-04-19 15:21 ` Benoît Thébaudeau
2013-04-19 15:28 ` Benoît Thébaudeau
2013-04-19 15:41 ` Philip Paeps
2013-04-19 16:20 ` Tom Rini
2013-04-19 17:11 ` Marek Vasut
2013-04-19 4:10 ` [U-Boot] [PATCH 3/6] arm: imx: Fix u-boot-with-nand-spl.imx target Marek Vasut
2013-04-19 8:56 ` Benoît Thébaudeau
2013-04-19 11:16 ` Marek Vasut
2013-04-19 11:42 ` Benoît Thébaudeau
2013-04-19 11:51 ` Marek Vasut
2013-04-19 11:55 ` Tom Rini
2013-04-19 17:04 ` Marek Vasut
2013-04-19 4:10 ` [U-Boot] [PATCH 4/6] arm: mx5: Add SPL support code to MX5 Marek Vasut
2013-04-19 9:03 ` Benoît Thébaudeau
2013-04-19 13:10 ` Philip Paeps
2013-04-20 10:28 ` Marek Vasut
2013-04-21 0:38 ` Marek Vasut
2013-05-05 16:06 ` Stefano Babic
2013-04-19 4:10 ` [U-Boot] [PATCH 5/6] arm: mx5: Add NAND clock handling Marek Vasut
2013-04-19 9:02 ` Benoît Thébaudeau
2013-04-19 9:08 ` Benoît Thébaudeau
2013-04-19 11:18 ` Marek Vasut
2013-04-19 11:32 ` Benoît Thébaudeau
2013-05-05 16:04 ` Stefano Babic
2013-04-19 4:10 ` [U-Boot] [PATCH 6/6] arm: mx5: Add support for DENX M53EVK Marek Vasut
2013-04-19 5:52 ` Wolfgang Denk
2013-04-19 11:58 ` Marek Vasut
2013-04-19 12:58 ` Wolfgang Denk [this message]
2013-04-21 0:43 ` Marek Vasut
2013-04-21 6:35 ` Wolfgang Denk
2013-04-21 14:42 ` Marek Vasut
2013-04-21 22:13 ` Wolfgang Denk
2013-04-21 23:09 ` Marek Vasut
2013-04-22 11:19 ` Wolfgang Denk
2013-04-25 19:07 ` Marek Vasut
2013-04-19 9:22 ` Benoît Thébaudeau
2013-04-19 11:44 ` Marek Vasut
2013-04-19 12:54 ` Benoît Thébaudeau
2013-04-19 13:56 ` Benoît Thébaudeau
2013-04-19 14:49 ` Fabio Estevam
2013-04-21 2:32 ` Marek Vasut
2013-04-19 8:15 ` [U-Boot] [PATCH 1/6] imx: Align the imximage header and payload to multiples of 4k Benoît Thébaudeau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130419125836.69EC2200566@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox