public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: common: Use a global definition for 'min3'
Date: Fri, 19 Apr 2013 13:29:12 +0200	[thread overview]
Message-ID: <201304191329.12280.marex@denx.de> (raw)
In-Reply-To: <1366364300-20988-1-git-send-email-gautam.vivek@samsung.com>

Dear Vivek Gautam,

> We can use a common global method for calculating minimum of
> 3 numbers. Put the same in 'common header' and let 'ehci'
> use it.
> 
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>

Applied, thanks

> ---
>  drivers/usb/host/ehci-hcd.c |   10 ----------
>  include/common.h            |    5 +++++
>  2 files changed, 5 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 19d4352..e0f3e4b 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -603,16 +603,6 @@ fail:
>  	return -1;
>  }
> 
> -static inline int min3(int a, int b, int c)
> -{
> -
> -	if (b < a)
> -		a = b;
> -	if (c < a)
> -		a = c;
> -	return a;
> -}
> -
>  int
>  ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer,
>  		 int length, struct devrequest *req)
> diff --git a/include/common.h b/include/common.h
> index 0cfa6a8..611edca 100644
> --- a/include/common.h
> +++ b/include/common.h
> @@ -211,6 +211,11 @@ typedef void (interrupt_handler_t)(void *);
>  #define MIN(x, y)  min(x, y)
>  #define MAX(x, y)  max(x, y)
> 
> +static inline int min3(int a, int b, int c)
> +{
> +	return min(min(a, b), c);
> +}
> +
>  /*
>   * Return the absolute value of a number.
>   *

Best regards,
Marek Vasut

  reply	other threads:[~2013-04-19 11:29 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-12 11:04 [U-Boot] [PATCH v3 0/8] usb: ss: Some fixes and cleanup for USB super-speed support Vivek Gautam
2013-04-12 11:04 ` [U-Boot] [PATCH v3 1/8] usb: common: Weed out USB_**_PRINTFs from usb framework Vivek Gautam
2013-04-12 11:04 ` [U-Boot] [PATCH v3 2/8] USB: Some cleanup prior to USB 3.0 interface addition Vivek Gautam
2013-04-12 11:04 ` [U-Boot] [PATCH v3 3/8] usb: hub: Power-cycle on root-hub ports Vivek Gautam
2013-04-19 19:00   ` [U-Boot] [U-Boot, v3, " Julius Werner
2013-04-22  8:21     ` Vivek Gautam
2013-04-22 22:02       ` Julius Werner
2013-04-23  6:45         ` Vivek Gautam
2013-04-12 11:04 ` [U-Boot] [PATCH v3 4/8] usb: Update device class in usb device's descriptor Vivek Gautam
2013-04-19 18:39   ` [U-Boot] [U-Boot, v3, " Julius Werner
2013-04-12 11:04 ` [U-Boot] [PATCH v3 5/8] usb: hub: Fix enumration timeout Vivek Gautam
2013-04-12 11:04 ` [U-Boot] [PATCH v3 6/8] USB: SS: Add support for Super Speed USB interface Vivek Gautam
2013-04-19 18:22   ` [U-Boot] [U-Boot, v3, " Julius Werner
2013-04-19 18:38     ` Marek Vasut
2013-04-19 20:32       ` Julius Werner
2013-04-20 11:57         ` Marek Vasut
2013-04-22  6:46           ` Vivek Gautam
2013-04-23  2:24             ` Marek Vasut
2013-04-23  6:46               ` Vivek Gautam
2013-04-22  6:43     ` Vivek Gautam
2013-04-22 22:14       ` Julius Werner
2013-04-23  4:39         ` Vivek Gautam
2013-04-12 11:04 ` [U-Boot] [PATCH v3 7/8] usb: hub: Reset only usb 2.0 ports Vivek Gautam
2013-04-23 17:23   ` [U-Boot] [U-Boot,v3,7/8] " Julius Werner
2013-04-24  0:21     ` Marek Vasut
2013-04-24  6:08       ` Vivek Gautam
2013-04-30 12:24         ` Vivek Gautam
2013-04-30 17:11           ` Marek Vasut
2013-04-12 11:04 ` [U-Boot] [PATCH v3 8/8] usb: common: Use a global macro for 'min3' Vivek Gautam
2013-04-14 17:11   ` Marek Vasut
2013-04-19  9:38     ` [U-Boot] [PATCH] usb: common: Use a global definition " Vivek Gautam
2013-04-19 11:29       ` Marek Vasut [this message]
2013-04-22 13:45         ` Tom Rini
2013-04-24  6:19           ` Vivek Gautam
2013-04-24  6:21             ` Vivek Gautam
2013-04-24 12:03               ` Marek Vasut
2013-04-14 17:14 ` [U-Boot] [PATCH v3 0/8] usb: ss: Some fixes and cleanup for USB super-speed support Marek Vasut
2013-04-18  6:25   ` Vivek Gautam
2013-04-18 12:38     ` Marek Vasut
2013-04-18 13:08       ` Vivek Gautam
2013-04-14 18:13 ` Marek Vasut
2013-04-18  6:24   ` Vivek Gautam
2013-04-18 10:59     ` Vivek Gautam
2013-04-18 11:08       ` Vivek Gautam
2013-04-18 12:43         ` Marek Vasut
2013-04-18 17:11           ` Julius Werner
2013-04-18 19:15             ` Marek Vasut
2013-04-19  4:51               ` Vivek Gautam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201304191329.12280.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox