From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Fri, 19 Apr 2013 19:11:04 +0200
Subject: [U-Boot] [PATCH 2/6] nand: Add SPL_NAND support to mxc_nand_spl
In-Reply-To: <20130419130013.GA246@twoflower.paeps.cx>
References: <1366344655-8535-1-git-send-email-marex@denx.de>
	<1366344655-8535-2-git-send-email-marex@denx.de>
	<20130419130013.GA246@twoflower.paeps.cx>
Message-ID: <201304191911.04499.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Philip Paeps,

> On 2013-04-19 06:10:51 (+0200), Marek Vasut <marex@denx.de> wrote:
> > To avoid the old function which are used with the nand_spl/ stuff
> > getting in the way of NAND SPL framework, the macro
> > CONFIG_SPL_NAND_LEGACY was introduced and two remaining legacy
> > boards were adjusted. These board need to be either fixed or
> > removed in the long run, but I don't have either.
> 
> It sounds like "fixing" these boards is mainly a matter of confirming
> that a configuration for them based around CONFIG_SPL_FRAMEWORK will fit
> in 2K.  If so, I don't think there is any reason to keep legacy support
> around.

These boards are too limited, so we can do nothing about them but to keep this 
hack in.

> > +void nand_init(void) {}
> > +void nand_deselect(void) {}
> 
> Couldn't you just rename nfc_nand_init() to nand_init()?

What good would that do?

Best regards,
Marek Vasut