[U-Boot] [PATCH 6/6] arm: mx5: Add support for DENX M53EVK

Marek Vasut
2013-04-21T00:43:05Z

Dear Wolfgang Denk,

> Dear Marek Vasut,
>
> In message <201304191358.25181.marex@denx.de> you wrote:
> > > > +#define CONFIG_LOADADDR 0x70800000
> > > > +#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR
> > >
> > > What do we need CONFIG_LOADADDR for?
> >
> > For this stuff, the "loadaddr" env variable. I have kinda idea to kill
> > this and unify it to CONFIG_SYS_LOAD_ADDR all around, what do you think?
>
> Why CONFIG_SYS_* ?

What do you suggest then?

> > include/env_default.h:#ifdef CONFIG_LOADADDR
> > include/env_default.h: "loadaddr=" __stringify(CONFIG_LOADADDR)
> > "\0"
>
> Indeed - I missed this one. I only checked C and asm sources, and
> cound not find a single reference...

It's also contained in LARGE amount of config files of course :(

> So arch/blackfin/include/asm/config.h and include/env_default.h are
> the only locateions that refer to CONFIG_LOADADDR ? This should
> indeed be cleaned up. [But this is not related to your patch any
> longer.]
>
>
> Best regards,
>
> Wolfgang Denk

Best regards,
Marek Vasut