From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/6] arm: mx5: Add support for DENX M53EVK
Date: Sun, 21 Apr 2013 04:32:59 +0200 [thread overview]
Message-ID: <201304210433.00130.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5ARFgzU+qwvLYjCSPm9k8P-65s_GiCemjEVAU+ZmrbGtg@mail.gmail.com>
Dear Fabio Estevam,
[...]
> > +u32 get_board_rev(void)
> > +{
> > + struct iim_regs *iim = (struct iim_regs *)IMX_IIM_BASE;
> > + struct fuse_bank *bank = &iim->bank[0];
> > + struct fuse_bank0_regs *fuse =
> > + (struct fuse_bank0_regs *)bank->fuse_regs;
> > + int rev = readl(&fuse->gp[6]);
> > +
> > + return (get_cpu_rev() & ~(0xF << 8)) | (rev & 0xF) << 8;
> > +}
>
> Can't you just remove this get_board_rev() from the board file and use
> the generic one instead?
There's no such thing for mx5, only for mx6.
I fixed the rest, but I left the multiline comments. It's the same on m28 and I
consider it more readable.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-04-21 2:32 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 4:10 [U-Boot] [PATCH 1/6] imx: Align the imximage header and payload to multiples of 4k Marek Vasut
2013-04-19 4:10 ` [U-Boot] [PATCH 2/6] nand: Add SPL_NAND support to mxc_nand_spl Marek Vasut
2013-04-19 8:38 ` Benoît Thébaudeau
2013-04-19 9:35 ` Benoît Thébaudeau
2013-04-19 11:14 ` Marek Vasut
2013-04-19 11:55 ` Benoît Thébaudeau
2013-04-19 13:46 ` Benoît Thébaudeau
2013-04-19 17:08 ` Marek Vasut
2013-04-20 13:00 ` Benoît Thébaudeau
2013-04-19 17:06 ` Marek Vasut
2013-04-20 13:06 ` Benoît Thébaudeau
2013-04-20 17:09 ` Marek Vasut
2013-04-19 13:00 ` Philip Paeps
2013-04-19 14:48 ` Philip Paeps
2013-04-19 14:53 ` Benoît Thébaudeau
2013-04-19 15:09 ` Philip Paeps
2013-04-19 15:21 ` Benoît Thébaudeau
2013-04-19 15:28 ` Benoît Thébaudeau
2013-04-19 15:41 ` Philip Paeps
2013-04-19 16:20 ` Tom Rini
2013-04-19 17:11 ` Marek Vasut
2013-04-19 4:10 ` [U-Boot] [PATCH 3/6] arm: imx: Fix u-boot-with-nand-spl.imx target Marek Vasut
2013-04-19 8:56 ` Benoît Thébaudeau
2013-04-19 11:16 ` Marek Vasut
2013-04-19 11:42 ` Benoît Thébaudeau
2013-04-19 11:51 ` Marek Vasut
2013-04-19 11:55 ` Tom Rini
2013-04-19 17:04 ` Marek Vasut
2013-04-19 4:10 ` [U-Boot] [PATCH 4/6] arm: mx5: Add SPL support code to MX5 Marek Vasut
2013-04-19 9:03 ` Benoît Thébaudeau
2013-04-19 13:10 ` Philip Paeps
2013-04-20 10:28 ` Marek Vasut
2013-04-21 0:38 ` Marek Vasut
2013-05-05 16:06 ` Stefano Babic
2013-04-19 4:10 ` [U-Boot] [PATCH 5/6] arm: mx5: Add NAND clock handling Marek Vasut
2013-04-19 9:02 ` Benoît Thébaudeau
2013-04-19 9:08 ` Benoît Thébaudeau
2013-04-19 11:18 ` Marek Vasut
2013-04-19 11:32 ` Benoît Thébaudeau
2013-05-05 16:04 ` Stefano Babic
2013-04-19 4:10 ` [U-Boot] [PATCH 6/6] arm: mx5: Add support for DENX M53EVK Marek Vasut
2013-04-19 5:52 ` Wolfgang Denk
2013-04-19 11:58 ` Marek Vasut
2013-04-19 12:58 ` Wolfgang Denk
2013-04-21 0:43 ` Marek Vasut
2013-04-21 6:35 ` Wolfgang Denk
2013-04-21 14:42 ` Marek Vasut
2013-04-21 22:13 ` Wolfgang Denk
2013-04-21 23:09 ` Marek Vasut
2013-04-22 11:19 ` Wolfgang Denk
2013-04-25 19:07 ` Marek Vasut
2013-04-19 9:22 ` Benoît Thébaudeau
2013-04-19 11:44 ` Marek Vasut
2013-04-19 12:54 ` Benoît Thébaudeau
2013-04-19 13:56 ` Benoît Thébaudeau
2013-04-19 14:49 ` Fabio Estevam
2013-04-21 2:32 ` Marek Vasut [this message]
2013-04-19 8:15 ` [U-Boot] [PATCH 1/6] imx: Align the imximage header and payload to multiples of 4k Benoît Thébaudeau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304210433.00130.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox