From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Sun, 21 Apr 2013 04:32:59 +0200
Subject: [U-Boot] [PATCH 6/6] arm: mx5: Add support for DENX M53EVK
In-Reply-To: <CAOMZO5ARFgzU+qwvLYjCSPm9k8P-65s_GiCemjEVAU+ZmrbGtg@mail.gmail.com>
References: <1366344655-8535-1-git-send-email-marex@denx.de>
	<1366344655-8535-6-git-send-email-marex@denx.de>
	<CAOMZO5ARFgzU+qwvLYjCSPm9k8P-65s_GiCemjEVAU+ZmrbGtg@mail.gmail.com>
Message-ID: <201304210433.00130.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Fabio Estevam,

[...]
> > +u32 get_board_rev(void)
> > +{
> > +       struct iim_regs *iim = (struct iim_regs *)IMX_IIM_BASE;
> > +       struct fuse_bank *bank = &iim->bank[0];
> > +       struct fuse_bank0_regs *fuse =
> > +               (struct fuse_bank0_regs *)bank->fuse_regs;
> > +       int rev = readl(&fuse->gp[6]);
> > +
> > +       return (get_cpu_rev() & ~(0xF << 8)) | (rev & 0xF) << 8;
> > +}
> 
> Can't you just remove this get_board_rev() from the board file and use
> the generic one instead?

There's no such thing for mx5, only for mx6.

I fixed the rest, but I left the multiline comments. It's the same on m28 and I 
consider it more readable.

Best regards,
Marek Vasut