From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sun, 21 Apr 2013 16:42:56 +0200 Subject: [U-Boot] [PATCH 6/6] arm: mx5: Add support for DENX M53EVK In-Reply-To: <20130421063518.DA10910029D@atlas.denx.de> References: <1366344655-8535-1-git-send-email-marex@denx.de> <201304210243.05923.marex@denx.de> <20130421063518.DA10910029D@atlas.denx.de> Message-ID: <201304211642.56723.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang Denk, > Dear Marek Vasut, > > In message <201304210243.05923.marex@denx.de> you wrote: > > > > > What do we need CONFIG_LOADADDR for? > > > > > > > > For this stuff, the "loadaddr" env variable. I have kinda idea to > > > > kill this and unify it to CONFIG_SYS_LOAD_ADDR all around, what do > > > > you think? > > > > > > Why CONFIG_SYS_* ? > > > > What do you suggest then? > > If we unify it, then we should use CONFIG_LOADADDR - this is a user > defined preference setting, not really a system / hardware dependent > one. OK > > > > include/env_default.h:#ifdef CONFIG_LOADADDR > > > > include/env_default.h: "loadaddr=" __stringify(CONFIG_LOADADDR) > > > > "\0" > > > > > > Indeed - I missed this one. I only checked C and asm sources, and > > > cound not find a single reference... > > > > It's also contained in LARGE amount of config files of course :( > > Yes, they set it for this single place where it gets used. Do you want me to fix it or will you ? Best regards, Marek Vasut