[U-Boot] [PATCH 6/6] arm: mx5: Add support for DENX M53EVK

Wolfgang Denk
2013-04-21T06:35:18Z

Dear Marek Vasut,

In message <201304210243.05923.marex@denx.de> you wrote:
>
> > > > What do we need CONFIG_LOADADDR for?
> > >
> > > For this stuff, the "loadaddr" env variable. I have kinda idea to kill
> > > this and unify it to CONFIG_SYS_LOAD_ADDR all around, what do you think?
> >
> > Why CONFIG_SYS_* ?
>
> What do you suggest then?

If we unify it, then we should use CONFIG_LOADADDR - this is a user
defined preference setting, not really a system / hardware dependent
one.

> > > include/env_default.h:#ifdef CONFIG_LOADADDR
> > > include/env_default.h: "loadaddr=" __stringify(CONFIG_LOADADDR)
> > > "\0"
> >
> > Indeed - I missed this one. I only checked C and asm sources, and
> > cound not find a single reference...
>
> It's also contained in LARGE amount of config files of course :(

Yes, they set it for this single place where it gets used.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Successful and fortunate crime is called virtue. - Seneca