From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 13/14] i2c: zynq: Add support for Xilinx Zynq
Date: Mon, 22 Apr 2013 12:09:10 -0400 [thread overview]
Message-ID: <20130422160910.GU14952@bill-the-cat> (raw)
In-Reply-To: <bd8bb6f424c7065c11acf133939aa60202adc4a3.1366641836.git.michal.simek@xilinx.com>
On Mon, Apr 22, 2013 at 04:52:11PM +0200, Michal Simek wrote:
> Support Xilinx Zynq i2c controller.
>
> Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Adding Heiko (http://patchwork.ozlabs.org/patch/238560/) ...
> ---
> arch/arm/include/asm/arch-zynq/hardware.h | 2 +
> drivers/i2c/Makefile | 1 +
> drivers/i2c/zynq_i2c.c | 304 ++++++++++++++++++++++++++++++
There's 3 new checkpatch warnings here, please fix. Also:
> --- a/arch/arm/include/asm/arch-zynq/hardware.h
> +++ b/arch/arm/include/asm/arch-zynq/hardware.h
> @@ -31,6 +31,8 @@
> #define CONFIG_ZYNQ_GEM_BASEADDR1 0xE000C000
> #define CONFIG_ZYNQ_SDHCI_BASEADDR0 0xE0100000
> #define CONFIG_ZYNQ_SDHCI_BASEADDR1 0xE0101000
> +#define CONFIG_ZYNQ_I2C_BASEADDR0 0xE0004000
> +#define CONFIG_ZYNQ_I2C_BASEADDR1 0xE0005000
Same comment as before about CONFIG in <hardware.h>
> +/* Control register fields */
> +#define ZYNQ_I2C_CONTROL_RW 0x00000001
'#define<space>', fix globally please.
> + /* Temporarily disable restart (by clearing hold)... */
> + /* It doesn't seem to work. */
/*
* Multi line comments go like this
*/
[snip]
> +# define CONFIG_HARD_I2C 1
No need for training 1 here.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130422/7d0f9194/attachment.pgp>
next prev parent reply other threads:[~2013-04-22 16:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 14:51 [U-Boot] Xilinx Zynq patches Michal Simek
2013-04-22 14:51 ` [U-Boot] [PATCH 01/14] arm: zynq: U-Boot udelay < 1000 FIX Michal Simek
2013-04-22 14:52 ` [U-Boot] [PATCH 02/14] zynq: Move scutimer baseaddr to hardware.h Michal Simek
2013-04-22 15:55 ` Tom Rini
2013-04-22 14:52 ` [U-Boot] [PATCH 03/14] net: phy: Define Marvell 88e1518 phy Michal Simek
2013-04-22 14:52 ` [U-Boot] [PATCH 04/14] net: gem: Remove WRAP bit from TX buffer description Michal Simek
2013-04-22 14:52 ` [U-Boot] [PATCH 05/14] net: gem: Simplify return path in zynq_gem_recv Michal Simek
2013-04-22 14:52 ` [U-Boot] [PATCH 06/14] net: gem: Do not initialize BDs again Michal Simek
2013-04-22 14:52 ` [U-Boot] [PATCH 07/14] net: gem: Fix gem driver on 1Gbps LAN Michal Simek
2013-04-22 14:52 ` [U-Boot] [PATCH 08/14] zynq: Move macros to hardware.h Michal Simek
2013-04-22 16:02 ` Tom Rini
2013-04-22 14:52 ` [U-Boot] [PATCH 09/14] net: gem: Pass phy address to init Michal Simek
2013-04-22 14:52 ` [U-Boot] [PATCH 10/14] net: gem: Preserve clk on emio interface Michal Simek
2013-04-22 14:52 ` [U-Boot] [PATCH 11/14] net: gem: Add support for phy autodetection Michal Simek
2013-04-22 14:52 ` [U-Boot] [PATCH 12/14] mmc: Add support for Xilinx Zynq sdhci controller Michal Simek
2013-04-22 14:52 ` [U-Boot] [PATCH 13/14] i2c: zynq: Add support for Xilinx Zynq Michal Simek
2013-04-22 16:09 ` Tom Rini [this message]
2013-04-22 14:52 ` [U-Boot] [PATCH 14/14] fpga: Add support for loading bitstream " Michal Simek
2013-04-22 16:29 ` Tom Rini
2013-04-22 16:29 ` [U-Boot] Xilinx Zynq patches Tom Rini
2013-04-23 10:46 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130422160910.GU14952@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox