From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] net: ks8851_mll: add ethernet support
Date: Tue, 23 Apr 2013 11:34:06 -0400 [thread overview]
Message-ID: <20130423153406.GG14952@bill-the-cat> (raw)
In-Reply-To: <1366712248-17343-2-git-send-email-voice.shen@atmel.com>
On Tue, Apr 23, 2013 at 06:17:27PM +0800, Bo Shen wrote:
> From: Roberto Cerati <roberto.cerati@bticino.it>
>
> The device interface is 16 bits wide.
> All the available packets are read from the incoming fifo.
[snip]
> +/* union ks_tx_hdr - tx header data
> + * @txb: The header as bytes
/*
* union ks_tx_hdr...
Please fix globally.
[snip]
> +#define RXFSHR_ERR (RXFSHR_RXCE | RXFSHR_RXRF |\
#define<space> please, thanks.
Looks fine aside from these style problems however, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130423/9179269a/attachment.pgp>
next prev parent reply other threads:[~2013-04-23 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 10:17 [U-Boot] [PATCH 0/2] Enable network support on at91sam9n12ek board Bo Shen
2013-04-23 10:17 ` [U-Boot] [PATCH 1/2] net: ks8851_mll: add ethernet support Bo Shen
2013-04-23 15:34 ` Tom Rini [this message]
2013-04-24 1:20 ` Bo Shen
2013-04-24 1:38 ` Tom Rini
2013-04-24 1:48 ` Bo Shen
2013-04-23 10:17 ` [U-Boot] [PATCH 2/2] ARM: at91sam9n12: add network support with ksz8851_16mll Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130423153406.GG14952@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox