From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 25 Apr 2013 15:36:25 +0200 Subject: [U-Boot] [PATCH V2 6/6] arm: mx5: Add support for DENX M53EVK In-Reply-To: <5178D93B.9040104@denx.de> References: <1366559547-9063-1-git-send-email-marex@denx.de> <201304242052.43002.marex@denx.de> <5178D93B.9040104@denx.de> Message-ID: <201304251536.25699.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stefano Babic, > On 24/04/2013 20:52, Marek Vasut wrote: > >> But you forget that a single image can be saved on multiple storage: > >> u-boot.imx can be stored on SD or NOR or SPI-NOR, and that is the reason > >> for having SOC-specific extension. > >> > >> I agree with Benoit: at the moment, only people working with i.MX know > >> that u-boot.im runs on SD. The third solution proposed by Benoit has the > >> drawback that probably not all boards need u-boot.imx (a board without > >> SD for example). At least we need an update of the README, but I think > >> it is not bad to have a new entry in boards.cfg. > >> > >> Apart of that and not related to this patch, if we in future use SPL > >> also for booting from SD, we can get a single way to boot from different > >> storage. TI based SOCs already do this: same SPL, it checks from SD and > >> NAND. > > > > Ok, I fail to grasp what is wanted from me. Shall I rework the patch > > somehow? How? Do we want m53evk_sd and m53evk_nand targets ? > > At least add documentation in the README. It is only your choice if you > will add two different targets to boards.cfg I'd prefer not to do that. We're currently booting from NAND and SD, so we use u-boot.imx resp. u-boot-with-nand-spl.imx there. But using the BOOT_FROM "nand" in the imximage.cfg is indeed wrong. We should focus on fixing that. We can now pre-process the imximage.cfg with CPP, so why don't we just replace BOOT_FROM "foobar" with BOOT_OFFSET CONFIG_IMX_BOOT_OFFSET as mentioned by someone in the thread already and setup the offset either in board config file or boards.cfg and even have some default value? Best regards, Marek Vasut