[U-Boot] [PATCH v3 08/11] usb: ehci: add Faraday USB 2.0 EHCI support

Marek Vasut
2013-04-29T22:50:14Z

Dear Kuo-Jung Su,

> 2013/4/26 Marek Vasut <marex@denx.de>:
> > Dear Kuo-Jung Su,
> >
> >> From: Kuo-Jung Su <dantesu@faraday-tech.com>
> >>
> >> This patch add supports to both Faraday FUSBH200 and FOTG210,
> >> these controllers slightly differ from standard EHCI specification.
> >
> > How do they differ?
>
> 1. The reserved registers (0x1C - 0x3F) and CONFIGFLAG (0x40) register
> are not only un-implemented, but also removed from its register address
> space, which means we have to update the 'struct ehci_hcor' of ehci.h
>
> 2. FUSBH200/FOTG210 doesn't properly follow the ECHI for ISOC
> implementations. (It should be a hardware bug, but no one wants to fix
> it.)
>
> I'll add these description to commit log at next patch.

Mhmmm ... maybe you can add some hooks into ehci-hcd driver instead of poluting
it with ifdefs ? Weak-aliased functions would probably work best to contain your
weird stuff in your driver only.

Best regards,
Marek Vasut