public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: mxs: Preprocess u-boot.bd so they contain full path
Date: Mon, 29 Apr 2013 01:02:57 +0200	[thread overview]
Message-ID: <201304290102.57765.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKo8jmK6SoTQgOsdNF3fqsdkX5Lr3FGwnywmb0FR9Je4gA@mail.gmail.com>

Dear Otavio Salvador,

> On Sun, Apr 28, 2013 at 3:39 PM, Marek Vasut <marex@denx.de> wrote:
> > The u-boot-imx23.bd and u-boot-imx28.bd need to be preprocessed,
> > otherwise they have issues with out-of-tree build where elftosb tool
> > couldn't sometimes find the u-boot.bin and spl/u-boot-spl.bin .
> > 
> > Preprocess these .bd files with sed and insert full path to u-boot.bin
> > and spl/u-boot-spl.bin to prevent this issue. Moreover, to avoid adding
> > more churn into main Makefile, move all this preprocessing and u-boot.sb
> > generation into CPU directory instead.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: Stefano Babic <sbabic@denx.de>
> 
> Please Cc me in 'mxs' patches.
> 
> >  Makefile                                   |    7 ++-----
> >  arch/arm/cpu/arm926ejs/mxs/Makefile        |   10 ++++++++++
> >  arch/arm/cpu/arm926ejs/mxs/u-boot-imx23.bd |    4 ++--
> >  arch/arm/cpu/arm926ejs/mxs/u-boot-imx28.bd |    4 ++--
> 
> As you'll be processing this '.bd' files with sed, I think naming the
> u-boot.imx2[38].bd.in could make it easier to understand when someone
> not familiar with the code looks at it.

Not really, just keep them as they were.

> Just due curiosity how did you find it failed? I did try to build it
> with out-of-tree using MAKEALL and had no issues. Is it reproducable
> with higher number of parallel tasks?

Not sure anymore, I had this fix on my todo so I did it.

Best regards,
Marek Vasut

  reply	other threads:[~2013-04-28 23:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-28 18:39 [U-Boot] [PATCH] arm: mxs: Preprocess u-boot.bd so they contain full path Marek Vasut
2013-04-28 21:10 ` Otavio Salvador
2013-04-28 23:02   ` Marek Vasut [this message]
2013-04-28 23:08     ` Otavio Salvador
2013-04-28 23:13       ` Marek Vasut
2013-04-28 23:21         ` Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201304290102.57765.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox