From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 29 Apr 2013 01:13:14 +0200 Subject: [U-Boot] [PATCH] arm: mxs: Preprocess u-boot.bd so they contain full path In-Reply-To: References: <1367174391-5505-1-git-send-email-marex@denx.de> <201304290102.57765.marex@denx.de> Message-ID: <201304290113.14649.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Otavio Salvador, > On Sun, Apr 28, 2013 at 8:02 PM, Marek Vasut wrote: > > Dear Otavio Salvador, > > > >> On Sun, Apr 28, 2013 at 3:39 PM, Marek Vasut wrote: > >> > The u-boot-imx23.bd and u-boot-imx28.bd need to be preprocessed, > >> > otherwise they have issues with out-of-tree build where elftosb tool > >> > couldn't sometimes find the u-boot.bin and spl/u-boot-spl.bin . > >> > > >> > Preprocess these .bd files with sed and insert full path to u-boot.bin > >> > and spl/u-boot-spl.bin to prevent this issue. Moreover, to avoid > >> > adding more churn into main Makefile, move all this preprocessing and > >> > u-boot.sb generation into CPU directory instead. > >> > > >> > Signed-off-by: Marek Vasut > >> > Cc: Fabio Estevam > >> > Cc: Stefano Babic > >> > >> Please Cc me in 'mxs' patches. > >> > >> > Makefile | 7 ++----- > >> > arch/arm/cpu/arm926ejs/mxs/Makefile | 10 ++++++++++ > >> > arch/arm/cpu/arm926ejs/mxs/u-boot-imx23.bd | 4 ++-- > >> > arch/arm/cpu/arm926ejs/mxs/u-boot-imx28.bd | 4 ++-- > >> > >> As you'll be processing this '.bd' files with sed, I think naming the > >> u-boot.imx2[38].bd.in could make it easier to understand when someone > >> not familiar with the code looks at it. > > > > Not really, just keep them as they were. > > When doing 'in-tree' build it will end changing the file itself, won't it? $OBJTREE/u-boot.bd will be produced, so no, read the patch again. > >> Just due curiosity how did you find it failed? I did try to build it > >> with out-of-tree using MAKEALL and had no issues. Is it reproducable > >> with higher number of parallel tasks? > > > > Not sure anymore, I had this fix on my todo so I did it. > > Right; no problem. This approach does makes sense, but I'd prefer a '.in' > file. > > -- > Otavio Salvador O.S. Systems > E-mail: otavio at ossystems.com.br http://www.ossystems.com.br > Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br Best regards, Marek Vasut