From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Tue, 30 Apr 2013 00:50:14 +0200
Subject: [U-Boot] [PATCH v3 08/11] usb: ehci: add Faraday USB 2.0 EHCI
	support
In-Reply-To: <CAK65tU40Be6oZC3YO_U7DoQrMFsx=XMapAdaCjUiEEQN53F9og@mail.gmail.com>
References: <1366963360-2987-1-git-send-email-dantesu@gmail.com>
	<201304261419.22683.marex@denx.de>
	<CAK65tU40Be6oZC3YO_U7DoQrMFsx=XMapAdaCjUiEEQN53F9og@mail.gmail.com>
Message-ID: <201304300050.14943.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Kuo-Jung Su,

> 2013/4/26 Marek Vasut <marex@denx.de>:
> > Dear Kuo-Jung Su,
> > 
> >> From: Kuo-Jung Su <dantesu@faraday-tech.com>
> >> 
> >> This patch add supports to both Faraday FUSBH200 and FOTG210,
> >> these controllers slightly differ from standard EHCI specification.
> > 
> > How do they differ?
> 
> 1. The reserved registers (0x1C - 0x3F) and CONFIGFLAG (0x40) register
>     are not only un-implemented, but also removed from its register address
>     space, which means we have to update the 'struct ehci_hcor' of ehci.h
> 
> 2. FUSBH200/FOTG210 doesn't properly follow the ECHI for ISOC
> implementations. (It should be a hardware bug, but no one wants to fix
> it.)
> 
> I'll add these description to commit log at next patch.

Mhmmm ... maybe you can add some hooks into ehci-hcd driver instead of poluting 
it with ifdefs ? Weak-aliased functions would probably work best to contain your 
weird stuff in your driver only.

Best regards,
Marek Vasut