From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] ARM: Tegra: USB: Add driver support for Tegra30/Tegra114
Date: Tue, 30 Apr 2013 13:20:12 -0400 [thread overview]
Message-ID: <20130430172012.GQ25397@bill-the-cat> (raw)
In-Reply-To: <5FBF8E85CA34454794F0F7ECBA79798F37AC7648F8@HQMAIL04.nvidia.com>
On Tue, Apr 30, 2013 at 09:21:18AM -0700, Tom Warren wrote:
> Marek,
>
> > -----Original Message-----
> > From: Marek Vasut [mailto:marex at denx.de]
> > Sent: Monday, April 29, 2013 4:47 PM
> > To: Jim Lin
> > Cc: u-boot at lists.denx.de; Tom Warren; Stephen Warren
> > Subject: Re: [PATCH 2/3] ARM: Tegra: USB: Add driver support for
> > Tegra30/Tegra114
> >
> > Dear Jim Lin,
> >
> > > Tegra30 and Tegra114 are compatible except 1. T30 takes 55 ms to
> > > finish Port Reset. T114 takes
> > > 50 ms.
> > > 2. PLL parameters
> > >
> > > Tested on Tegra20 Harmony/Seaboard, Tegra30 Cardhu, and Tegra114
> > > Dalmore platforms. All works well.
> > >
> > > Signed-off-by: Jim Lin <jilin@nvidia.com>
> > > ---
> > > arch/arm/include/asm/arch-tegra/clk_rst.h | 10 +
> > > arch/arm/include/asm/arch-tegra/usb.h | 249 ------------------
> > > arch/arm/include/asm/arch-tegra114/tegra.h | 1 +
> > > arch/arm/include/asm/arch-tegra114/usb.h | 287
> > +++++++++++++++++++++
> > > arch/arm/include/asm/arch-tegra20/usb.h | 279
> > +++++++++++++++++++++
> > > arch/arm/include/asm/arch-tegra30/usb.h | 294
> > ++++++++++++++++++++++
> >
> > Do we now have three copies of the same stuff ?
>
> When only T20 was supported (for USB), there was a common
> (arch-tegra/usb.h) header. That's been moved to arch-tegra20/usb.h,
> and (unfortunately) there are 2 new usb.h files due to the HW
> differences in the registers between T20 and T30/T114. I don't see
> any easy way to have a common usb.h file for Tegra w/o adding ugly
> #ifdefs to the USB register space struct(s).
Just how different are they? Are all of the related defines and masks
different too? Do we have conflicts? Moved registers? Just conflicting
values? A quick peek shows '30' and '114' are pretty similar, except
for masks. Maybe splitting the struct up so you can discard some of the
reserved gaps, run-time checking to see if we can or cannot use a
particular part of the struct?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130430/90bd70dd/attachment.pgp>
next prev parent reply other threads:[~2013-04-30 17:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 9:21 [U-Boot] [PATCH 0/3] Tegra: USB: EHCI: add Tegra30 compatible support Jim Lin
2013-04-29 9:21 ` [U-Boot] [PATCH 1/3] ARM: Tegra: FDT: Add USB support for T20/T30/T114 Jim Lin
2013-05-02 19:10 ` Stephen Warren
2013-05-03 11:07 ` Jim Lin
2013-05-03 14:43 ` Stephen Warren
2013-05-03 11:48 ` Venu Byravarasu
2013-04-29 9:21 ` [U-Boot] [PATCH 2/3] ARM: Tegra: USB: Add driver support for Tegra30/Tegra114 Jim Lin
2013-04-29 23:46 ` Marek Vasut
2013-04-30 16:21 ` Tom Warren
2013-04-30 17:09 ` Marek Vasut
2013-04-30 17:20 ` Tom Rini [this message]
2013-05-01 16:16 ` Tom Warren
2013-05-01 16:45 ` Tom Rini
2013-05-01 19:33 ` Marek Vasut
2013-05-01 23:20 ` Tom Warren
2013-05-01 23:23 ` Tom Warren
2013-05-02 9:50 ` Jim Lin
2013-05-02 11:38 ` Marek Vasut
2013-05-02 15:38 ` Tom Warren
2013-05-02 19:29 ` Stephen Warren
2013-05-03 10:53 ` Jim Lin
2013-05-03 14:46 ` Stephen Warren
2013-04-29 9:21 ` [U-Boot] [PATCH 3/3] Tegra: Config: Enable Tegra30/Tegra114 USB function Jim Lin
2013-05-02 19:30 ` Stephen Warren
2013-05-03 15:02 ` [U-Boot] [PATCH 0/3] Tegra: USB: EHCI: add Tegra30 compatible support Stephen Warren
2013-05-08 16:11 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130430172012.GQ25397@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox