From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/7] cmd: fpga: Move fpga_loadbitstream to fpga.c
Date: Wed, 1 May 2013 11:03:19 -0400 [thread overview]
Message-ID: <20130501150319.GU25397@bill-the-cat> (raw)
In-Reply-To: <f2aa08035905689cfd59cd524106e4962e62660d.1367398749.git.michal.simek@xilinx.com>
On Wed, May 01, 2013 at 10:59:20AM +0200, Michal Simek wrote:
> In bitstream decoding you can directly check device
> which you want to load and in fpga.c are fpga_validate
> and fpga_dev_info functions which should be used for it.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
[snip]
> +++ b/drivers/fpga/fpga.c
[snip]
> +#else
> + printf("Bitstream support only for Xilinx devices\n");
> + return FPGA_FAIL;
> +#endif
How about we re-work this as a __weak fpga_loadbitstream in
drivers/fpga/fpga.c that just says "Bitstream support not implemented
for this FPGA device", return FPGA_FAIL, and move the xilinx one into
drivers/fpga/xilinx.c ?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130501/07279156/attachment.pgp>
next prev parent reply other threads:[~2013-05-01 15:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 8:59 [U-Boot] [PATCH v2 0/7] FPGA cleanup + zynq support Michal Simek
2013-05-01 8:59 ` [U-Boot] [PATCH v2 1/7] fpga: Clean coding style Michal Simek
2013-05-01 8:59 ` [U-Boot] [PATCH v2 2/7] fpga: Fix debug message compilation error Michal Simek
2013-05-01 8:59 ` [U-Boot] [PATCH v2 3/7] cmd: fpga: Clean coding style Michal Simek
2013-05-01 8:59 ` [U-Boot] [PATCH v2 4/7] cmd: fpga: Move fpga_loadbitstream to fpga.c Michal Simek
2013-05-01 15:03 ` Tom Rini [this message]
2013-05-01 15:29 ` Michal Simek
2013-05-01 8:59 ` [U-Boot] [PATCH v2 5/7] cmd: fpga: Do not include net.h Michal Simek
2013-05-01 8:59 ` [U-Boot] [PATCH v2 6/7] fpga: zynq: Add support for loading bitstream Michal Simek
2013-05-01 8:59 ` [U-Boot] [PATCH v2 7/7] fpga: Check device name against bitstream name Michal Simek
2013-05-01 15:14 ` [U-Boot] [PATCH v2 0/7] FPGA cleanup + zynq support Tom Rini
2013-05-01 15:35 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130501150319.GU25397@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox