From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 0/7] FPGA cleanup + zynq support
Date: Wed, 1 May 2013 11:14:09 -0400 [thread overview]
Message-ID: <20130501151409.GV25397@bill-the-cat> (raw)
In-Reply-To: <cover.1367398749.git.michal.simek@xilinx.com>
On Wed, May 01, 2013 at 10:59:16AM +0200, Michal Simek wrote:
> Fpga code is pretty old and none has tried to clean it up.
> My attempt is related to new code I want to push to mainline
> which is add support for checking bitstream and if bitstream
> is valid for the selected device.
> For this I need to do cleanup code and move code
> from cmd_fpga.c to fpga.c in driver folder.
Aside from my comments to 4/7, everything else looks good and a step
forward.
Looking at 7/7 however, it seems like:
- None of CONFIG_SYS_XILINX_IF_* are used
- CONFIG_SYS_... model definitions... aren't used, now that CONFIG_FPGA
isn't a bitfield anymore, and are only used by configs that still act
like it is.
So we could just clean up and remove those parts of the header, yes?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130501/ad6f53a4/attachment.pgp>
next prev parent reply other threads:[~2013-05-01 15:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 8:59 [U-Boot] [PATCH v2 0/7] FPGA cleanup + zynq support Michal Simek
2013-05-01 8:59 ` [U-Boot] [PATCH v2 1/7] fpga: Clean coding style Michal Simek
2013-05-01 8:59 ` [U-Boot] [PATCH v2 2/7] fpga: Fix debug message compilation error Michal Simek
2013-05-01 8:59 ` [U-Boot] [PATCH v2 3/7] cmd: fpga: Clean coding style Michal Simek
2013-05-01 8:59 ` [U-Boot] [PATCH v2 4/7] cmd: fpga: Move fpga_loadbitstream to fpga.c Michal Simek
2013-05-01 15:03 ` Tom Rini
2013-05-01 15:29 ` Michal Simek
2013-05-01 8:59 ` [U-Boot] [PATCH v2 5/7] cmd: fpga: Do not include net.h Michal Simek
2013-05-01 8:59 ` [U-Boot] [PATCH v2 6/7] fpga: zynq: Add support for loading bitstream Michal Simek
2013-05-01 8:59 ` [U-Boot] [PATCH v2 7/7] fpga: Check device name against bitstream name Michal Simek
2013-05-01 15:14 ` Tom Rini [this message]
2013-05-01 15:35 ` [U-Boot] [PATCH v2 0/7] FPGA cleanup + zynq support Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130501151409.GV25397@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox