From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 2 May 2013 13:38:44 +0200
Subject: [U-Boot] [PATCH 2/3] ARM: Tegra: USB: Add driver support for
	Tegra30/Tegra114
In-Reply-To: <1367488229.13142.3.camel@jilin-desktop>
References: <1367227275-7713-1-git-send-email-jilin@nvidia.com>
	<201305012133.33281.marex@denx.de>
	<1367488229.13142.3.camel@jilin-desktop>
Message-ID: <201305021338.44738.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Jim Lin,

[...]

> > 
> > This is a problem with the struct-based access indeed. I agree with Tom
> > it'd be worth to at least try distilling the common part into header
> > shared between those three CPUs.
> 
> OK. I will add this into next version of patch.
> 
> > btw you're also adding some kernel-doc-alike annotations to functions,
> > why don't you follow kerneldoc style altogether?
> 
> I don't understand what you meant here.
> Could you give me an example? Like what I did is wrong or not good. And
> what is correct or better one.

These kinds of annotations:

+/*
+ * Process a list of nodes, adding them to our list of SDMMC ports.
+ *
+ * @param blob          fdt blob
+ * @param node_list     list of nodes to process (any <=0 are ignored)
+ * @param count         number of nodes to process
+ * @return 0 if ok, -1 on error
+ */

See http://www.denx.de/wiki/U-Boot/CodingStyle@the bottom for the right 
style.

Best regards,
Marek Vasut