From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 5/7] mxs: spl_mem_init: Remove erroneous DDR setting
Date: Fri, 3 May 2013 04:25:32 +0200 [thread overview]
Message-ID: <201305030425.32401.marex@denx.de> (raw)
In-Reply-To: <1367534661-13502-6-git-send-email-festevam@gmail.com>
Dear Fabio Estevam,
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> On mx23 there is no 'DRAM init complete' in register HW_DRAM_CTL18.
>
> Remove this erroneous setting.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v2:
> - None
> Changes since v1:
> - Newly introduced as the previous patch is now splitted.
>
> arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
> b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c index 300da0a..df25535 100644
> --- a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
> +++ b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
> @@ -279,10 +279,6 @@ static void mx23_mem_init(void)
>
> setbits_le32(MXS_DRAM_BASE + 0x40, 1 << 19);
> setbits_le32(MXS_DRAM_BASE + 0x40, 1 << 11);
> -
> - /* Wait for bit 10 (DRAM init complete) in DRAM_CTL18 */
> - while (!(readl(MXS_DRAM_BASE + 0x48) & (1 << 10)))
> - ;
Is there no such similar bit indicating the init completed?
> }
> #endif
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-05-03 2:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 22:44 [U-Boot] [PATCH v3 0/9] mx23: Make DDR initialization stable Fabio Estevam
2013-05-02 22:44 ` [U-Boot] [PATCH v3 1/7] mx23: Fix pad voltage selection bit Fabio Estevam
2013-05-03 2:24 ` Marek Vasut
2013-05-03 2:33 ` Otavio Salvador
2013-05-03 2:34 ` Marek Vasut
2013-05-03 2:34 ` Fabio Estevam
2013-05-02 22:44 ` [U-Boot] [PATCH v3 2/7] mx23evk: Fix DDR pin iomux settings Fabio Estevam
2013-05-03 2:24 ` Marek Vasut
2013-05-03 2:35 ` Fabio Estevam
2013-05-03 2:37 ` Marek Vasut
2013-05-03 2:51 ` Fabio Estevam
2013-05-03 3:22 ` Marek Vasut
2013-05-02 22:44 ` [U-Boot] [PATCH v3 3/7] mx23_olinuxino: " Fabio Estevam
2013-05-02 22:44 ` [U-Boot] [PATCH v3 4/7] mxs: spl_mem_init: Fix comment about start bit Fabio Estevam
2013-05-02 22:44 ` [U-Boot] [PATCH v3 5/7] mxs: spl_mem_init: Remove erroneous DDR setting Fabio Estevam
2013-05-03 2:25 ` Marek Vasut [this message]
2013-05-03 2:37 ` Fabio Estevam
2013-05-03 2:50 ` Marek Vasut
2013-05-02 22:44 ` [U-Boot] [PATCH v3 6/7] mxs: spl_mem_init: Skip the initialization of some DRAM_CTL registers Fabio Estevam
2013-05-03 2:26 ` Marek Vasut
2013-05-03 2:33 ` Otavio Salvador
2013-05-02 22:44 ` [U-Boot] [PATCH v3 7/7] mxs: spl_mem_init: Change EMI port priority Fabio Estevam
2013-05-03 2:20 ` [U-Boot] [PATCH v3 0/9] mx23: Make DDR initialization stable Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305030425.32401.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox