From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 1/7] mx23: Fix pad voltage selection bit
Date: Fri, 3 May 2013 16:11:33 +0200 [thread overview]
Message-ID: <201305031611.33438.marex@denx.de> (raw)
In-Reply-To: <1367589613-18065-2-git-send-email-festevam@gmail.com>
Dear Fabio Estevam,
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> On mx23 the pad voltage selection bit needs to be always '0', since '1' is
> a reserved value.
>
> For example:
>
> Pin 108, EMI_A06 pin voltage selection:
> 0= 1.8V (mDDR) or 2.5V (DDR1);
> 1= reserved.
>
> Fix the pad voltage definitions for the mx23 case.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Acked-by: Marek Vasut <marex@denx.de>
> ---
> Changes since v3:
> - Add Marek's ack
> Changes since v2:
> - Only place PAD_3V3 inside the if/else block
> Changes since v1:
> - Newly introduced
>
> arch/arm/include/asm/arch-mxs/iomux.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/include/asm/arch-mxs/iomux.h
> b/arch/arm/include/asm/arch-mxs/iomux.h index 4288715..f46895e 100644
> --- a/arch/arm/include/asm/arch-mxs/iomux.h
> +++ b/arch/arm/include/asm/arch-mxs/iomux.h
> @@ -71,7 +71,11 @@ typedef u32 iomux_cfg_t;
> #define PAD_16MA 3
>
> #define PAD_1V8 0
> +#if defined CONFIG_MX28
Uh, #if defined(CONFIG_MX28) ?
> #define PAD_3V3 1
> +#else
> +#define PAD_3V3 0
> +#endif
>
> #define PAD_NOPULL 0
> #define PAD_PULLUP 1
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-05-03 14:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 14:00 [U-Boot] [PATCH v4 0/7] mx23: Make DDR initialization stable Fabio Estevam
2013-05-03 14:00 ` [U-Boot] [PATCH v4 1/7] mx23: Fix pad voltage selection bit Fabio Estevam
2013-05-03 14:11 ` Marek Vasut [this message]
2013-05-03 14:00 ` [U-Boot] [PATCH v4 2/7] mx23evk: Fix DDR pin iomux settings Fabio Estevam
2013-05-03 14:00 ` [U-Boot] [PATCH v4 3/7] mx23_olinuxino: " Fabio Estevam
2013-05-03 14:00 ` [U-Boot] [PATCH v4 4/7] mxs: spl_mem_init: Fix comment about start bit Fabio Estevam
2013-05-03 14:00 ` [U-Boot] [PATCH v4 5/7] mxs: spl_mem_init: Remove erroneous DDR setting Fabio Estevam
2013-05-03 14:00 ` [U-Boot] [PATCH v4 6/7] mxs: spl_mem_init: Skip the initialization of some DRAM_CTL registers Fabio Estevam
2013-05-03 14:12 ` Marek Vasut
2013-05-03 14:00 ` [U-Boot] [PATCH v4 7/7] mxs: spl_mem_init: Change EMI port priority Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305031611.33438.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox